Code analysis with external libraries not working in VS SDK style project

[ErikEJ]

• SqlPackage or DacFx Version: 162.4 (?)
• .NET Framework (Windows-only) or .NET Core:
• Environment (local platform and source/target platforms): VS with SDK style

Steps to Reproduce:

Using this (but maybe my expectations are too high?)

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build">
  <Sdk Name="Microsoft.Build.Sql" Version="0.2.5-preview" />
  <PropertyGroup>
    <Name>Database1</Name>
    <DSP>Microsoft.Data.Tools.Schema.Sql.Sql160DatabaseSchemaProvider</DSP>
    <ModelCollation>1033, CI</ModelCollation>
    <RootNamespace>Database1</RootNamespace>
    <AssemblyName>Database1</AssemblyName>
	<RunSqlCodeAnalysis>true</RunSqlCodeAnalysis>
  </PropertyGroup>

   <ItemGroup>
    <PackageReference Include="ErikEJ.DacFX.SqlServer.Rules" Version="1.1.1" />
    <PackageReference Include="ErikEJ.DacFX.TSQLSmellSCA" Version="1.1.1" />
  </ItemGroup>
</Project>

[ErikEJ]

Still broken in VS 17.13 preview 2.1 with 1.0.0-rc1

[mrlmachado]

@ErikEJ I got it working by adding a few extra lines in my .sqlproj file.
I agree with you that it should work out of the box by referencing the packages though.

Code example:

<?xml version="1.0" encoding="utf-8"?>
<Project DefaultTargets="Build">
  <Sdk Name="Microsoft.Build.Sql" Version="1.0.0-rc1" />
  <PropertyGroup>
    <Name>Database1</Name>
    <DSP>Microsoft.Data.Tools.Schema.Sql.Sql160DatabaseSchemaProvider</DSP>
    <ModelCollation>1033, CI</ModelCollation>
    <RootNamespace>Database1</RootNamespace>
    <AssemblyName>Database1</AssemblyName>
    <RunSqlCodeAnalysis>true</RunSqlCodeAnalysis>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="ErikEJ.DacFX.SqlServer.Rules" Version="1.1.1" GeneratePathProperty="true" />
    <PackageReference Include="ErikEJ.DacFX.TSQLSmellSCA" Version="1.1.1" GeneratePathProperty="true" />
  </ItemGroup>

  <Target Name="SpecifyCustomCodeAnalysisPath" BeforeTargets="PrepareForBuild">
    <Message Importance="high" Text="Ensuring the SqlCodeAnalysisAssemblyPaths variable is set correctly" />
    <PropertyGroup>
      <SqlCodeAnalysisAssemblyPaths Condition="'$(SqlCodeAnalysisAssemblyPaths)' == ''">$(PkgErikEJ_DacFX_SqlServer_Rules)\lib\net462\ErikEJ.DacFX.SqlServer.Rules.dll;$(PkgErikEJ_DacFX_TSQLSmellSCA)\lib\net462\ErikEJ.DacFX.TSQLSmellSCA.dll</SqlCodeAnalysisAssemblyPaths>
    </PropertyGroup>
  </Target>
</Project>

[ErikEJ]

Interesting.

I dont think the 1.1.1 packages contain anything in the net462 folder..

[mrlmachado]

Don't mind the version, it's just an example. I could make it work building the SqlCodeAnalysis package using net462 framework. Couldn't make it working with any higher versions.