From 8f2680f65735d0fa3a593666e2be12b9f0c99d23 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Tue, 26 Nov 2024 13:12:16 -0700 Subject: [PATCH] existence proof that is_deriv isn't needed hctdb.py set is_deriv, but only actually used the equivalent is_gradient flag --- utils/hct/hctdb.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/utils/hct/hctdb.py b/utils/hct/hctdb.py index 19220d6d1a..f3bdaa8ad3 100644 --- a/utils/hct/hctdb.py +++ b/utils/hct/hctdb.py @@ -82,7 +82,6 @@ def __init__(self, name, **kwargs): self.is_allowed = True # whether this instruction is allowed in a DXIL program self.oload_types = "" # overload types if applicable self.fn_attr = "" # attribute shorthands: rn=does not access memory,ro=only reads from memory, - self.is_deriv = False # whether this is some kind of derivative self.is_gradient = False # whether this requires a gradient calculation self.is_feedback = False # whether this is a sampler feedback op self.is_wave = False # whether this requires in-wave, cross-lane functionality @@ -5523,11 +5522,6 @@ def UFI(name, **mappings): "," ): self.name_idx[i].is_gradient = True - for i in "DerivCoarseX,DerivCoarseY,DerivFineX,DerivFineY".split(","): - assert ( - self.name_idx[i].is_gradient == True - ), "all derivatives are marked as requiring gradients" - self.name_idx[i].is_deriv = True # TODO - some arguments are required to be immediate constants in DXIL, eg resource kinds; add this information # consider - report instructions that are overloaded on a single type, then turn them into non-overloaded version of that type