getFeatureFlags on ConfigurationMapFeatureFlagProvider fails - Treats array as single object

[strickie]

When calling getFeatureFlags on ConfigurationMapFeatureFlagProvider the call fails becaus the code call treats array as single object

In

FeatureManagement-JavaScript/src/schema/validator.ts

Line 8 in 8fe0efd

export function validateFeatureFlag(featureFlag: any): void {

In featureProvider.ts

FeatureManagement-JavaScript/src/featureProvider.ts

Line 30 in 8fe0efd

async getFeatureFlag(featureName: string): Promise<FeatureFlag | undefined> {

The same validateFeatureFlag function is called with both a single FeatureFlag and array of FeatureFlag but the function doesn't handle arrays.

[vputsenko]

Facing with same issue. FEATURE_FLAGS_KEY contains not a single feature flag but array of feature flags so it is incorrect to call this function for this array.

Interesting how typescript compiled this code ) look like validateFeatureFlag. in source code we have
export function validateFeatureFlag(featureFlag: any): void

that "any" wad written to avoid casts inside validateFeatureFlag function. However you can write validateFeatureFlag(flag: Partial< FeatureFlag >) and achieve same effect but get this error covered by compiler.

[zhiyuanliang-ms]

Hey, @strickie @vputsenko Sorry for the late response. Looking into the issue.

[zhiyuanliang-ms]

@vputsenko @strickie Sorry for the mistake. This is a bad bug. I didn't notice it during the code review. My fault. Sorry, orz
BTW, we didn't have testcases for getFeatureFlags. That is a huge oversight. I will add testcase for it and fix the bug immediately.

We added this in 2.0.0-preview.3. Other packages before it should be fine. I will publish a bug fix release very soon. Sorry for the inconvenience.

[zhiyuanliang-ms]

#78

[vputsenko]

Great, Thank you!