Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericTopSlotExplorer ExplorerDecision Exception #52

Open
HappyCoderMan opened this issue Jul 16, 2016 · 3 comments
Open

GenericTopSlotExplorer ExplorerDecision Exception #52

HappyCoderMan opened this issue Jul 16, 2016 · 3 comments

Comments

@HappyCoderMan
Copy link

I have an app that uses decisionService.ChooseRanking with 81 actions, and theGenericTopSlotExplorer ExplorerDecision threw its "Probabilities must sum to one." exception as shown in this screenshot.

I put a red box around the "total -1f" in the watch window, which is the condition checked before the exception is thrown.

image

@JohnLangford
Copy link
Contributor

This looks like a precision issue to me since floats work to 1e-6
precision. Maybe we should upgrade the probabilities to doubles? Either
that or use a less stringent test.

-John

On Sat, Jul 16, 2016 at 3:12 PM, ErikOmberg [email protected]
wrote:

I have an app that uses decisionService.ChooseRanking with 81 actions, and
theGenericTopSlotExplorer ExplorerDecision threw its "Probabilities must
sum to one." exception as shown in this screenshot.

I put a red box around the "total -1f" in the watch window, which is the
condition checked before the exception is thrown.

[image: image]
https://cloud.githubusercontent.com/assets/8632110/16896664/452da758-4b5f-11e6-84d0-e6538783ded0.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#52, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAE25jopU5PNSVVRrFOyZXGr61C4N0N5ks5qWS07gaJpZM4JOE2y
.

@eisber
Copy link
Collaborator

eisber commented Jul 18, 2016

@JohnLangford: change to 1e-3?

@eisber
Copy link
Collaborator

eisber commented Jul 21, 2016

We’ll change to 1e-4.

Markus

eisber added a commit that referenced this issue Jul 22, 2016
improved end to end tests
version bump
closing issue #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants