Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs]: Improve documentation for metadata #34094

Closed
vitalets opened this issue Dec 19, 2024 · 2 comments
Closed

[Docs]: Improve documentation for metadata #34094

vitalets opened this issue Dec 19, 2024 · 2 comments
Assignees
Labels

Comments

@vitalets
Copy link
Contributor

Page(s)

https://playwright.dev/docs/next/api/class-testconfig#test-config-metadata

Description

1. Current metadata example does not pass TypeScript check:

import { defineConfig } from '@playwright/test';

export default defineConfig({
  metadata: 'acceptance tests',
});

Result:

Type 'string' is not assignable to type 'Metadata'.

2. Documentation should mention the certain fields that are allowed in metadata, e.g.

export type Metainfo = {
  'revision.id'?: string;
  'revision.author'?: string;
  'revision.email'?: string;
  'revision.subject'?: string;
  'revision.timestamp'?: number | Date;
  'revision.link'?: string;
  'ci.link'?: string;
  'timestamp'?: number
};
@dgozman
Copy link
Contributor

dgozman commented Jan 9, 2025

We discussed this issue, and are not sure how to improve it.

@dgozman dgozman closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2025
@dgozman
Copy link
Contributor

dgozman commented Jan 9, 2025

@vitalets We are open to bringing the commit info into the metadata under an option in the config. If that goes public, then we'll definitely document the fields and the html reporter will show them nicely. Would you like to contribute?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants