Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fabricitem)!: enable multi-format support #171

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

feat(fabricitem)!: enable multi-format support #171

wants to merge 4 commits into from
+770 −193

Conversation

DariuszPorowski
Copy link
Member

📥 Pull Request

❓ What are you trying to address

WIP

✨ Description of new changes

WIP

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Changelog Preview

v0.1.0-dev - January 09, 2025

💥 Breaking

  • #111 The format attribute is now REQUIRED for Resources/Data-Sources with definition support.
    Currently applicable to the following Resources/Data-Sources: Report, Notebook, Semantic Model, and Spark Job Definition.

✨ Added

  • #168 Added support for multi-format Notebook Resource/Data-Source.
    By using format attribute, you can now define the format of the Notebook Resource/Data-Source. Accepted values are jpynb, and py.

  • #135 Definition support in the fabric_eventhouse Resource

  • #156 Definition support in the fabric_eventhouse Data-Sources

@DariuszPorowski DariuszPorowski added this to the 2025-01 milestone Dec 23, 2024
@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from ea6ecc7 to 684ccbc Compare December 23, 2024 17:57
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Code Coverage

Package Line Rate Complexity Health
github.com/microsoft/terraform-provider-fabric/internal/auth 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/customtypes 75% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/planmodifiers 62% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/typeutils 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/framework/validators 67% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/functions 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/fabricitem 72% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/transforms 63% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/pkg/utils 84% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/config 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/provider/utils 70% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/capacity 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/dashboard 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datamart 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/datapipeline 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/domain 41% 0 ➖
github.com/microsoft/terraform-provider-fabric/internal/services/environment 87% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventhouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/eventstream 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqldatabase 82% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/kqlqueryset 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/lakehouse 86% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mirroredwarehouse 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlexperiment 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/mlmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/notebook 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/paginatedreport 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/report 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/semanticmodel 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/spark 74% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sparkjobdefinition 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/sqlendpoint 100% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/warehouse 92% 0 ✔
github.com/microsoft/terraform-provider-fabric/internal/services/workspace 78% 0 ✔
Summary 73% (3897 / 5345) 0 ✔

Minimum allowed line rate is 40%

@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.69784% with 62 lines in your changes missing coverage. Please review.

Project coverage is 76.55%. Comparing base (5578a67) to head (381a9f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...mework/validators/regexp_if_attribute_is_one_of.go 52.08% 46 Missing ⚠️
.../pkg/fabricitem/models_resource_item_definition.go 57.14% 6 Missing ⚠️
...item/resource_item_config_definition_properties.go 0.00% 3 Missing ⚠️
internal/pkg/fabricitem/definition.go 96.77% 2 Missing ⚠️
internal/pkg/fabricitem/resource_schema.go 88.88% 2 Missing ⚠️
internal/provider/utils/values.go 66.66% 2 Missing ⚠️
internal/pkg/fabricitem/models_resource_item.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
- Coverage   76.58%   76.55%   -0.04%     
==========================================
  Files         148      150       +2     
  Lines       12631    12795     +164     
==========================================
+ Hits         9674     9795     +121     
- Misses       2952     2996      +44     
+ Partials        5        4       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from 684ccbc to a9e96cf Compare December 23, 2024 20:00
@DariuszPorowski DariuszPorowski force-pushed the feat/fabitem-multiformat branch from e597bc8 to 38543ed Compare January 9, 2025 03:31
@DariuszPorowski DariuszPorowski changed the title feat(fabricitem): enable multi-format support feat(fabricitem)!: enable multi-format support Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@DariuszPorowski DariuszPorowski

Labels
None yet
Projects
None yet
Milestone
2025-01
Development

Successfully merging this pull request may close these issues.

[FEAT] fabric_notebook support for .py file as definition source
2 participants
@DariuszPorowski @codecov-commenter