Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExpectedException codefix crashes with InvalidCastException #4542

Closed
Youssef1313 opened this issue Jan 7, 2025 · 0 comments · Fixed by #4560
Closed

ExpectedException codefix crashes with InvalidCastException #4542

Youssef1313 opened this issue Jan 7, 2025 · 0 comments · Fixed by #4560
Assignees
@Youssef1313
Labels
Area: Analyzers In-PR sprint
Milestone
MSTest 3.7.1 / Pl...

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jan 7, 2025 •
edited by pavelhorak
Loading

Found this while applying the codefix in some code base. The last statement in the method was var myVariable = .... Looks like we are incorrectly assuming ExpressionSyntax while we got a LocalDeclarationStatementSyntax.

System.InvalidCastException : Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Syntax.LocalDeclarationStatementSyntax' to type 'Microsoft.CodeAnalysis.CSharp.Syntax.ExpressionSyntax'.
   at Microsoft.CodeAnalysis.CSharp.SyntaxFactory.ParenthesizedLambdaExpression(ParameterListSyntax parameterList,CSharpSyntaxNode body)
   at async MSTest.Analyzers.AvoidExpectedExceptionAttributeFixer.WrapLastStatementWithAssertThrowsExceptionAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.CodeActions.CodeAction.GetChangedSolutionAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.CodeActions.CodeAction.ComputeOperationsAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.CodeActions.CodeAction.ComputePreviewOperationsAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.CodeActions.CodeAction.GetPreviewOperationsAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedAction.GetPreviewOperationsAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedAction.GetPreviewResultAsync(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.Editor.Implementation.Suggestions.SuggestedActionWithNestedFlavors.<>c__DisplayClass16_0.<GetPreviewAsync>b__0(<Unknown Parameters>)
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at async Microsoft.CodeAnalysis.Extensions.IExtensionManagerExtensions.PerformFunctionAsync[T](<Unknown Parameters>)

AB#2333380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Youssef1313 Youssef1313

Labels
Area: Analyzers In-PR sprint
Projects
None yet
Milestone
MSTest 3.7.1 / Platform 1.5.1
Development

Successfully merging a pull request may close this issue.

Fix ExpectedException codefix to handle few edge cases Youssef1313/testfx
1 participant
@Youssef1313