Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svg tag in HTML mode incorrectly marked invalid when closing tag spans more than one line #124215

Closed
zmwangx opened this issue May 20, 2021 · 1 comment
Closed

svg tag in HTML mode incorrectly marked invalid when closing tag spans more than one line #124215

zmwangx opened this issue May 20, 2021 · 1 comment
Assignees
@aeschli

Comments

@zmwangx
Copy link

zmwangx commented May 20, 2021

Issue Type: Bug

Open a HTML file with the following content

<!DOCTYPE html>
<html>
  <head>
    <title>Test</title>
  </head>
  <body>
    (<svg height="100" width="100">
      <circle cx="50" cy="50" r="40" stroke="black" stroke-width="3" fill="red" /></svg
    >)
    <p></p>
  </body>
</html>

This is valid HTML5 that passes W3C's validator. (The closing svg tag is broken up by Prettier.)

However, VSCode marks the svg closing tag as invalid, as well as everything after it:

image

VS Code version: Code 1.56.2 (054a929, 2021-05-12T17:44:30.902Z)
OS version: Darwin x64 20.4.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (12 x 3200)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 2, 2, 2
Memory (System) 16.00GB (0.31GB free)
Process Argv
Screen Reader no
VM 0%
@zmwangx zmwangx mentioned this issue May 20, 2021
Closed
johnsoncodehk added a commit to johnsoncodehk/vscode that referenced this issue May 20, 2021
@johnsoncodehk
Fixed svg end tag token
f776080 
microsoft#124215
@johnsoncodehk johnsoncodehk mentioned this issue May 20, 2021
Closed
@aeschli
Copy link
Contributor

aeschli commented May 20, 2021

This needs to be fixed in https://github.com/textmate/html.tmbundle.
They actually already have an issue for it: textmate/html.tmbundle#101
Closing as dup.

@aeschli aeschli closed this as completed May 20, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed svg end tag token johnsoncodehk/vscode
2 participants
@zmwangx @aeschli