Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Html script closing-tag not detected when occurs immediately after 2 slashes #50898

Closed
SDP190 opened this issue May 31, 2018 · 3 comments
Closed

Html script closing-tag not detected when occurs immediately after 2 slashes #50898

SDP190 opened this issue May 31, 2018 · 3 comments
Assignees
@aeschli
Labels
html HTML support issues

Comments

@SDP190
Copy link

SDP190 commented May 31, 2018 •
edited
Loading

Hi, I found a bug, with the html grammar in VS Code, when you place a closing script-tag in the same line immediately after 2 fwd slashes, as:
<script> //</script>
the grammar will not detect the closing tag, and will display it with wrong color format, see images.

This should be marked as a BUG, since a Closing-Tag after 2 slashes is perfectly valid HTML syntax, and so should it be interpreted in VS Code.

(See my post and conversation at vscode-textmate, and @alexandrudima suggestion here).

VS Code:
sample

Visual Studio 2015:
capture

  • VSCode Version: Version 1.23.0
    Commit 7c7da59
    Date 2018-05-03T16:44:55.614Z
    Shell 1.7.12
    Renderer 58.0.3029.110
    Node 7.9.0
    Architecture x64
  • OS Version: Windows 10 (x64) Version 10.0.17134

Steps to Reproduce:

  1. Open any html document with VSCode.
  2. Insert a script element in the document, and place the script's closing-tag immediately after 2 fwd slashes.

This issue does occur when all extensions are disabled too.
@vscodebot vscodebot bot added the html HTML support issues label May 31, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 1, 2018

Reproduced with

<!DOCTYPE html>
<html>
<head>
    <script>
        //</script>
</head>
<body>

</body>
</html>

It's a problem of the TextMate grammar and only affects syntax highlighting.
The HTML language server correctly detects the end script tag.

@aeschli aeschli mentioned this issue Jun 1, 2018
Open
@aeschli
Copy link
Contributor

aeschli commented Jun 1, 2018

This issue was moved to textmate/html.tmbundle#85

@aeschli aeschli closed this as completed Jun 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 1, 2018

We have #20488 as a debt item on our side.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
html HTML support issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aeschli @SDP190