backend/epoll: implement eventfd wakeup notification #128
+99
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added note, without this, trying to use any thread scheduled operation (like file io) will be very slow (up to 100ms). |
|
gentle ping @mitchellh |
steeve
force-pushed
the
steeve/epoll_eventfd
branch
2 times, most recently
from
476a87a to
5bc3ad9
Compare
When there is more than 256 events, the `events` slice could overflow when processing completions.
Tries to mimic what happens in backend/kqueue. Closes mitchellh#4
Since eventfd is now implemented.
Close might block, so dispatch it inside a threadpool.
If an immediate action is dispatched, the loop might block on epoll_wait even though only one action was requested.
steeve
force-pushed
the
steeve/epoll_eventfd
branch
from
5bc3ad9 to
003416b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to mimic what happens in backend/kqueue.
Closes #4