Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grouping rows in a popup doesn't work #1232

Open
szafirov opened this issue Dec 17, 2024 · 0 comments
Open

Grouping rows in a popup doesn't work #1232

szafirov opened this issue Dec 17, 2024 · 0 comments

Comments

@szafirov
Copy link

The instanceof Array check for setGroups doesn't work in iframes so it messes up the array by nesting it:
https://github.com/6pac/6pac.github.io/blob/master/SlickGrid/slick.dataview.js#L328

Should be replaced by Array.isArray or equivalent:
http://perfectionkills.com/instanceof-considered-harmful-or-how-to-write-a-robust-isarray/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant