Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Cache #60

Closed
tgetgood opened this issue Dec 20, 2017 · 2 comments
Closed

Add a Cache #60

tgetgood opened this issue Dec 20, 2017 · 2 comments

Comments

@tgetgood
Copy link
Collaborator

tgetgood commented Dec 20, 2017 •
edited
Loading

To daemonise effectively (regarding #48) we need a local cache on disk. Nothing fancy just hashes of the queries and timestamps. Global ttl.

This will also have a beneficial impact on development, and in normal use it will mean that if a query fails because it's too expensive (not in daemon mode) then the data grabbed does not get thrown away when you try again later.
@RichardLitt
Copy link
Member

Sounds good to me.

tgetgood added a commit to tgetgood/name-your-contributors that referenced this issue Jan 1, 2018
@tgetgood
feat: Added local disk cache
e390a59 
closes mntnr#60
tgetgood added a commit to tgetgood/name-your-contributors that referenced this issue Jan 11, 2018
@tgetgood
feat: Added local disk cache
c74876b 
closes mntnr#60
tgetgood added a commit to tgetgood/name-your-contributors that referenced this issue Jan 11, 2018
@tgetgood
feat: Added local disk cache
5bd0d57 
closes mntnr#60
@RichardLitt
Copy link
Member

🎉 This issue has been resolved in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tgetgood @RichardLitt