-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Running magic self-update
while on a VPN will hang
#267
Comments
I confirmed this morning that this problem isn't limited to |
Thanks for reporting! we'll look into it. |
can you try |
@zbowling just tried that but it unfortunately didn't change anything. |
I pushed a pre-release build of magic 0.6.0 that will likely resolve the deadlocking issue a few people have been hitting. You can install this, assuming magic isn't deadlocking for you, with magic self-update --prerelease. If it is I made a script to directly reinstall this pre-release: curl -ssL https://gist.githubusercontent.com/zbowling/4153d8db6dc98ff4ecd73fbe65f4df92/raw/55d9a64273c68b38d6b7d9a19911b27ab9d4d46f/fetch.sh | bash Then before invoking this new magic build run "export MAGIC_TELEMETRY=false" in your shell before invoking any commands and see if that resolves it for you. It seems our telemetry framework hangs magic rather than timing out when it can't reach our telemetry server in specific network setups (for reasons we haven't identified or when be able to reproduce locally) or initializing on a background thread like it supposed (a bug in that framework), even when you disable telemetry. In the next release we will probably replace it. |
I'll try this again once 0.6.0 of magic is released and report back. |
Bug description
When running
magic self-update
while on a VPN (in my case ProtonVPN) the command will hang indefinitely. It might be nice to either implement a fix that allows for running this command on a VPN, or exit the command with some error information.Steps to reproduce
magic self-update
.System information
The text was updated successfully, but these errors were encountered: