RUST-2112 Test connecting with tlsCertificateKeyFilePassword #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abr-egn
commented
Jan 14, 2025
etc/tls_cert_password/src/main.rs
Outdated
| let mut options = mongodb::options::ClientOptions::parse(std::env::var("MONGODB_URI").unwrap()) | ||
| .await | ||
| .unwrap(); | ||
| options.tls = Some(Tls::Enabled( |
There was a problem hiding this comment.
Since we're testing parsing elsewhere, I figure setting the options directly gives us slightly more coverage.
There was a problem hiding this comment.
it needs to set features on pkcs8
How about adding an entry to dev-dependencies for pkcs8 with the additional feature flags enabled? I did a test of this locally and it seems to work as long as the non-dev and dev dependencies don't have conflicting features and/or versions
... yup, that makes it much simpler, thank you! |
isabelatkinson
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUST-2112
I was originally hoping this could just be another test function in the suite with logic about when to run, but since it needs to set features on
pkcs8, it gets its own binary and buildvariant.