RUST-1231 Run tests using DEFAULT_MAX_POOL_SIZE
#980
Conversation
abr-egn
requested review from
isabelatkinson
and removed request for
patrickfreed
|
Swapped Patrick out for Isabel since he's no longer on the Rust driver team :) |
|
Merged |
src/test.rs
Outdated
| @@ -114,7 +113,7 @@ lazy_static! { | |||
|
|
|||
| pub(crate) fn update_options_for_testing(options: &mut ClientOptions) { | |||
| if options.max_pool_size.is_none() { | |||
| options.max_pool_size = Some(MAX_POOL_SIZE); | |||
| options.max_pool_size = Some(DEFAULT_MAX_POOL_SIZE); | |||
There was a problem hiding this comment.
I think we can remove this logic entirely since the driver will already apply this default internally.
| @@ -216,7 +217,7 @@ async fn load_balancing_test() { | |||
| let mut handler = EventHandler::new(); | |||
| let mut subscriber = handler.subscribe(); | |||
| let mut options = CLIENT_OPTIONS.get().await.clone(); | |||
| let max_pool_size = 10; | |||
| let max_pool_size = DEFAULT_MAX_POOL_SIZE; | |||
There was a problem hiding this comment.
ditto here, I think we just want min/max pool size to be the same, so line 224 can just assign to Some(DEFAULT_MAX_POOL_SIZE)
There was a problem hiding this comment.
I removed options.max_pool_size = Some(max_pool_size), but the max_pool_size variable is still needed nonetheless (it seems better to use it in multiple places in the method, rather than using DEFAULT_MAX_POOL_SIZE in those same places, and it is how it was done originally).
Don't implicitly set `max_pool_size` to `DEFAULT_MAX_POOL_SIZE`. RUST-1231
|
@isabelatkinson Could you please also merge the PR? Asking because I don't have the permission to do that. |
The tasks
compile-on-msrvandcheck-cargo-denyfail because of RUST-1780.RUST-1231