\MonterHealth\ApiFilterBundle\MonterHealthApiFilter::applyFilterResults does not deal correctly properties annotated with \Doctrine\ORM\Mapping\Embedded

[ste80pa]

Doctrine has a cool feature for separating concerns called Embeddables

take in example the scenario described at https://www.doctrine-project.org/projects/doctrine-orm/en/2.10/tutorials/embeddables.html and add a cotroller to retrieve users by api

<?php
use Doctrine\ORM\Mapping as ORM;
use MonterHealth\ApiFilterBundle\Annotation\ApiFilter;
use MonterHealth\ApiFilterBundle\Filter\SearchFilter;
/** 
 * @ORM\Entity(repositoryClass=UserRepository::class)
 * @ApiFilter(SearchFilter::class, properties={
 *     "address"
 *
 * }) */
class User
{
    /** @ORM\Embedded(class = "Address") */
    private $address;
}

<?php
use Doctrine\ORM\Mapping as ORM;
use MonterHealth\ApiFilterBundle\Annotation\ApiFilter;
use MonterHealth\ApiFilterBundle\Filter\SearchFilter;

/** @ORM\Embeddable */
class Address
{
    /** @ORM\Column(type = "string") */
    private $street;

    /** @ORM\Column(type = "string") */
    private $postalCode;

    /** @ORM\Column(type = "string") */
    private $city;

    /** @ORM\Column(type = "string") */
    private $country;
}

<?php
namespace App\Controller;

use App\Repository\UserRepository;
use MonterHealth\ApiFilterBundle\MonterHealthApiFilter;
use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Routing\Annotation\Route;

class UserController extends AbstractController
{
    /**
     * @Route("users", name="get_users", methods={"GET"})
     * @param Request $request
     * @param UserRepository $repository
     * @param MonterHealthApiFilter $monterHealthApiFilter
     * @return JsonResponse
     * @throws \ReflectionException
     */
    public function getBooks(Request $request, UserRepository $repository, MonterHealthApiFilter $monterHealthApiFilter): JsonResponse
    {
        $queryBuilder = $repository->findAllQueryBuilder();
        $monterHealthApiFilter->addFilterConstraints($queryBuilder, $repository->getClassName(), $request->query);

        return new JsonResponse($queryBuilder->getQuery()->getArrayResult());
    }
}

now after everything it is in place we invoke the api and what we expect it i to obtain users filtered by address.city = "Rome"

curl -X 'GET' 'http://127.0.0.1:8080/users?address:city=Rome&limit=20&page=1'

what happens in reality it is that the filter it is simply ignored or confused with a join.

After some debug i wrote a solution that i will submit soon

[monterhealth]

@ste80pa: Is this wish still relevant? If so, we will add the option in the latest version that uses attributes.

[ste80pa]

@monterhealth yes it is still relevant :D

[monterhealth]

@ste80pa Ok, we'll put it on our list!