-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can this be converted to sniffs for PHP_CodeSniffer? #28
Comments
+100 if we can do this - helps with IDE integration etc etc (finding someone who can do the work might be more difficult) |
Just leaving this here, it must be completed before something like this could be attempted: https://tracker.moodle.org/browse/CONTRIB-5732 |
For reference, link to (2y old) issue where a research about this was performed. https://tracker.moodle.org/browse/CONTRIB-4165 |
Just been thinking about this and wondering.. if we could disable all the 'dumb' rules in this plugin which can be replaced by sniffs. Then just leave the more intelligent checks here if they can't be replaced. It's not perfect, but I think it's advantageous to do the move because of tooling support. |
Work on this has started: https://github.com/moodlehq/moodle-cs/milestone/1 |
With PHP_CodeSniffer 2.0, I believe they have greatly improved their tokenizing of PHPDoc blocks. Would it now be possible to fold this into local_codechecker's PHP_CodeSniffer code standard?
The text was updated successfully, but these errors were encountered: