From 1bf70e46b5ace24b6712b0d7737a8193c5a590b2 Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:23:29 +0100 Subject: [PATCH 1/9] Moodle master branch was renamed to main --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 380fe77..995757c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -31,7 +31,7 @@ jobs: matrix: include: - php: '8.2' - moodle-branch: 'master' + moodle-branch: 'main' database: 'pgsql' - php: '8.1' moodle-branch: 'MOODLE_402_STABLE' From fb373d83c748086a892991b455f4784c145dc6c5 Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:28:17 +0100 Subject: [PATCH 2/9] Moodle main branch now requires Postgres 14 --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 995757c..f50a96c 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ jobs: services: postgres: - image: postgres:13 + image: postgres:14 env: POSTGRES_USER: 'postgres' POSTGRES_HOST_AUTH_METHOD: 'trust' From 6c0901b148a6326410124d42d038a3f22a0497eb Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:33:21 +0100 Subject: [PATCH 3/9] phpcs should only test up to the matrix php version --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f50a96c..e5bbdfc 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -89,7 +89,7 @@ jobs: - name: Moodle Code Checker if: ${{ always() }} - run: moodle-plugin-ci phpcs --max-warnings 0 + run: moodle-plugin-ci phpcs --test-version ${{ matrix.php }} --max-warnings 0 - name: Moodle PHPDoc Checker if: ${{ always() }} From 3923d3cae6b43f239df5da7d4444bc8bd254305f Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:43:43 +0100 Subject: [PATCH 4/9] ci - check Moodle 4.1 with PHP 8.1 --- .github/workflows/ci.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e5bbdfc..5780ab9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -36,6 +36,9 @@ jobs: - php: '8.1' moodle-branch: 'MOODLE_402_STABLE' database: 'mariadb' + - php: '8.1' + moodle-branch: 'MOODLE_401_STABLE' + database: 'pgsql' - php: '8.0' moodle-branch: 'MOODLE_401_STABLE' database: 'pgsql' From 968a091363a7256b46526b2365cf8b430b5bde4e Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:56:24 +0100 Subject: [PATCH 5/9] Behat tests use qtype_recordrtc --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 5780ab9..306bd68 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,6 +72,7 @@ jobs: - name: Install moodle-plugin-ci run: | + moodle-plugin-ci add-plugin moodle-qtype_recordrtc moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1 env: DB: ${{ matrix.database }} From d83fdf6b821f922accdd3e6b8a907ca7773df3c2 Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 20:59:04 +0100 Subject: [PATCH 6/9] Forgot organization --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 306bd68..272e991 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,7 +72,7 @@ jobs: - name: Install moodle-plugin-ci run: | - moodle-plugin-ci add-plugin moodle-qtype_recordrtc + moodle-plugin-ci add-plugin moodleou/moodle-qtype_recordrtc moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1 env: DB: ${{ matrix.database }} From 01d4aead7f7edd4122a8d965eda76f88f2d5595a Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Fri, 17 Jan 2025 21:05:26 +0100 Subject: [PATCH 7/9] Added dependency for qtype_recordrtc to install --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 272e991..9a40a89 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -72,6 +72,7 @@ jobs: - name: Install moodle-plugin-ci run: | + moodle-plugin-ci add-plugin moodleou/moodle-qbehaviour_selfassess moodle-plugin-ci add-plugin moodleou/moodle-qtype_recordrtc moodle-plugin-ci install --plugin ./plugin --db-host=127.0.0.1 env: From d6ee9df139ca2632bf9d2f3d2f98192abfcf35e0 Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Sat, 18 Jan 2025 00:01:00 +0100 Subject: [PATCH 8/9] Immediate Feedback behaviour outputs a button labeled "Check", not "Save" --- tests/behat/filter_embedquestion.feature | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/behat/filter_embedquestion.feature b/tests/behat/filter_embedquestion.feature index 032814c..c752ff9 100644 --- a/tests/behat/filter_embedquestion.feature +++ b/tests/behat/filter_embedquestion.feature @@ -111,7 +111,7 @@ Feature: Add an activity and embed a question inside that activity And I should see "The answer is true." @javascript - Scenario: Test display of Save button for embedded recordrtc question. + Scenario: Test display of Check button for embedded recordrtc question. Given the following "questions" exist: | questioncategory | qtype | name | idnumber | template | | Test questions | recordrtc | Record AV question | test1 | audio | @@ -122,4 +122,4 @@ Feature: Add an activity and embed a question inside that activity And I set the field "How the question behaves" to "Immediate feedback" And I press "Embed question" And I switch to "filter_embedquestion-iframe" iframe - And I should see "Save" + And I should see "Check" From 5bce2b98506a80ea53f8ed05b8f7e060821e0ee9 Mon Sep 17 00:00:00 2001 From: Daniel Poggenpohl Date: Sat, 18 Jan 2025 00:21:57 +0100 Subject: [PATCH 9/9] Dump behat failures --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9a40a89..a6f3421 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -122,4 +122,4 @@ jobs: - name: Behat features if: ${{ always() }} - run: moodle-plugin-ci behat --profile chrome + run: moodle-plugin-ci behat --profile chrome --dump