Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

joining by row name #21

Open
moodymudskipper opened this issue Sep 27, 2022 · 1 comment
Open

joining by row name #21

moodymudskipper opened this issue Sep 27, 2022 · 1 comment
Milestone

Comments

@moodymudskipper
Copy link
Owner

The tidy approach discourages row names but they still happen, should we provide a way to match by row names ? base::merge allows it using by = "row.names" or by = 0.

I don't like the former since it's confused with column names, the latter is not explicit and is coerced to character on a by vector so I don't love it either.

We might use by = "*row*".

I thought we might have a helper by_row() which is either recognised by NSE or is just NA with a class and printing method, but used in vectors the attribute/class will be lost by c() and the NSE handling would look awful.

So I think "row" it is.

@moodymudskipper
Copy link
Owner Author

@moodymudskipper moodymudskipper added this to the 0.2 milestone Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant