Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add prom-only test counter and statsd-only label #1094

Merged
merged 1 commit into from
Jan 14, 2025
Merged

add prom-only test counter and statsd-only label #1094

merged 1 commit into from
Jan 14, 2025

Conversation

jmhodges
Copy link
Contributor

Just making sure we're right about how the direct prometheus monitoring
isn't running.

Updates AUT-393

@jmhodges
add prom-only test counter and statsd-only label
4cfc34c 
Just making sure we're right about how the direct prometheus monitoring
isn't running.

Updates AUT-393
say-yawn
say-yawn approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@say-yawn say-yawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three test counter metrics being emitted:

  • Statsd metric name foobar_test with tag statsd:yes
  • Prom metric name foobar_test
  • Prom metric name prom_only_foobar_test

@jmhodges jmhodges marked this pull request as ready for review January 14, 2025 18:12
@jmhodges jmhodges requested review from a team as code owners January 14, 2025 18:12
@jmhodges jmhodges requested review from bhearsum and removed request for a team January 14, 2025 18:12
@jmhodges jmhodges enabled auto-merge (squash) January 14, 2025 18:12
@jmhodges jmhodges merged commit 0c16f44 into main Jan 14, 2025
14 checks passed
@jmhodges jmhodges deleted the aut-393-prom-only branch January 14, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcottner alexcottner alexcottner approved these changes

@say-yawn say-yawn say-yawn approved these changes

@bhearsum bhearsum Awaiting requested review from bhearsum bhearsum is a code owner automatically assigned from mozilla-services/autograph-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmhodges @say-yawn @alexcottner