Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support colorspace tag for OSD, Subtitles and overlay-add #10678

Open
natural-harmonia-gropius opened this issue Sep 24, 2022 · 4 comments
Open

Support colorspace tag for OSD, Subtitles and overlay-add #10678

natural-harmonia-gropius opened this issue Sep 24, 2022 · 4 comments
Labels
meta:feature-request

Comments

@natural-harmonia-gropius
Copy link
Contributor

The color space of the bgra file is not always same as the target color space.

conversion is already there, it follows --target-*.
image

Related to:
po5/thumbfast#24 (comment)
https://mpv.io/manual/master/#command-interface-overlay-add
@haasn
Copy link
Member

haasn commented Sep 24, 2022

If I understand you correctly, you want the ability to specify the primaries and transfer function as extra named parameters to overlay-add? That seems very doable, at least for gpu-next. I don't think gpu could handle it easily / at all.

@natural-harmonia-gropius
Copy link
Contributor Author

Thanks, supporting gpu-next is enough.

@dyphire dyphire mentioned this issue May 13, 2023
Closed
@po5 po5 mentioned this issue May 14, 2023
Open
@natural-harmonia-gropius
Copy link
Contributor Author

Better solution: #12149

@natural-harmonia-gropius natural-harmonia-gropius changed the title Support colorspace-hint for overlay-add Support colorspace tag for OSD, Subtitles and overlay-add Aug 17, 2023
@natural-harmonia-gropius
Copy link
Contributor Author

Apparently only this solution can support true HDR thumbnails

Also, it would be nice to have support for true HDR osd and subtitles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@haasn @natural-harmonia-gropius