Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Definition and the Completion don't work on Ruby 2.2 #44

Open
steiley opened this issue Oct 31, 2017 · 4 comments
Open

The Definition and the Completion don't work on Ruby 2.2 #44

steiley opened this issue Oct 31, 2017 · 4 comments
Assignees

Comments

@steiley
Copy link
Contributor

steiley commented Oct 31, 2017

I encountered the following error when trying to start the Definition or the Completion using the language server on Ruby 2.2.

NoMethodError: undefined method `fetch_values' for {:line=>80, :character=>33}:Hash
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-0.9.0/lib/language_server.rb:137:in `block in <module:LanguageServer>'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-0.9.0/lib/language_server.rb:46:in `call'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-0.9.0/lib/language_server.rb:46:in `block in run'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-protocol-0.4.0/lib/language_server/protocol/transport/stdio/reader.rb:27:in `call'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-protocol-0.4.0/lib/language_server/protocol/transport/stdio/reader.rb:27:in `read'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-0.9.0/lib/language_server.rb:35:in `run'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/gems/language_server-0.9.0/exe/language_server-ruby:8:in `<top (required)>'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/bin/language_server-ruby:23:in `load'
  /home/steiley/.rbenv/versions/2.2.7/lib/ruby/gems/2.2.0/bin/language_server-ruby:23:in `<top (required)>'

Actually there is no function called fetcth_values ​​in the Hash class of Ruby ​​2.2.
But I think It is not necessary to implement fetch_values for Ruby ​​2.2.
How about removing Ruby ​​2.2 from support?

@mtsmfm
Copy link
Owner

mtsmfm commented Oct 31, 2017

Wow, sorry the coverage isn't enough 🙇
I'd like to support Ruby 2.2 until EOL. (It will be this December though)
So I'll add test and fix this problem.

@steiley
Copy link
Contributor Author

steiley commented Oct 31, 2017

I see.
I understand that.

@mtsmfm mtsmfm self-assigned this Nov 12, 2017
@mathieujobin
Copy link

does that means this never worked?

@mtsmfm
Copy link
Owner

mtsmfm commented Feb 3, 2020

@mathieujobin
Sorry, I haven't fixed this problem before Ruby 2.2 EOL.
Are you still using 2.2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants