From 0ecfcc155ac0387ef9db3304611c6f3ef055ac1d Mon Sep 17 00:00:00 2001
From: Courtney Peverley <courtneyp@ucar.edu>
Date: Thu, 5 Dec 2024 15:26:05 -0700
Subject: [PATCH] Add diagnostics to TJ2016 test schemes (#170)

Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue
number):
Add state and tend diagnostics schemes to the test TJ2016 schemes so
that the tests will create history files. Also fix the tendency units
for wind variables.

Describe any changes made to the namelist: none

List all files eliminated and why: none

List all files added and what they do: none

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
M   test/test_schemes/suite_tj2016_sfc_pbl_hs.xml
M   test/test_schemes/suite_tj2016_precip.xml
- Add state and tend diagnostic schemes

M   schemes/tj2016/tj2016_sfc_pbl_hs.meta
- fix wind tendency units

List any test failures: none

Is this a science-changing update? New physics package, algorithm
change, tuning changes, etc? no.
---
 doc/NamesNotInDictionary.txt                 | 2 +-
 schemes/tj2016/tj2016_sfc_pbl_hs.meta        | 4 ++--
 test/test_suites/suite_tj2016_precip.xml     | 2 ++
 test/test_suites/suite_tj2016_sfc_pbl_hs.xml | 2 ++
 4 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/doc/NamesNotInDictionary.txt b/doc/NamesNotInDictionary.txt
index c966dac8..4cfd6aa1 100644
--- a/doc/NamesNotInDictionary.txt
+++ b/doc/NamesNotInDictionary.txt
@@ -1,7 +1,7 @@
 
 #######################
 Date/time of when script was run:
-2024-12-02 10:21:31.914990
+2024-12-04 09:38:58.707515
 #######################
 
 Non-dictionary standard names found in the following metadata files:
diff --git a/schemes/tj2016/tj2016_sfc_pbl_hs.meta b/schemes/tj2016/tj2016_sfc_pbl_hs.meta
index 9fdffe53..3f8903a4 100644
--- a/schemes/tj2016/tj2016_sfc_pbl_hs.meta
+++ b/schemes/tj2016/tj2016_sfc_pbl_hs.meta
@@ -169,7 +169,7 @@
   intent = in
 [ dudt ]
   standard_name = tendency_of_eastward_wind
-  units = m s-1
+  units = m s-2
   type = real | kind = kind_phys
   dimensions = (horizontal_loop_extent, vertical_layer_dimension)
   intent = out
@@ -181,7 +181,7 @@
   intent = in
 [ dvdt ]
   standard_name = tendency_of_northward_wind
-  units = m s-1
+  units = m s-2
   type = real | kind = kind_phys
   dimensions = (horizontal_loop_extent, vertical_layer_dimension)
   intent = out
diff --git a/test/test_suites/suite_tj2016_precip.xml b/test/test_suites/suite_tj2016_precip.xml
index 7f6dd40b..381767bc 100644
--- a/test/test_suites/suite_tj2016_precip.xml
+++ b/test/test_suites/suite_tj2016_precip.xml
@@ -5,6 +5,8 @@
     <scheme>tj2016_precip</scheme>
     <scheme>apply_heating_rate</scheme>
     <scheme>qneg</scheme>
+    <scheme>sima_state_diagnostics</scheme>
+    <scheme>sima_tend_diagnostics</scheme>
   </group>
 </suite>
 
diff --git a/test/test_suites/suite_tj2016_sfc_pbl_hs.xml b/test/test_suites/suite_tj2016_sfc_pbl_hs.xml
index 2da13e64..267d8ed1 100644
--- a/test/test_suites/suite_tj2016_sfc_pbl_hs.xml
+++ b/test/test_suites/suite_tj2016_sfc_pbl_hs.xml
@@ -7,6 +7,8 @@
     <scheme>apply_tendency_of_eastward_wind</scheme>
     <scheme>apply_tendency_of_northward_wind</scheme>
     <scheme>qneg</scheme>
+    <scheme>sima_state_diagnostics</scheme>
+    <scheme>sima_tend_diagnostics</scheme>
   </group>
 </suite>