Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to custom collector class #55

Open
mweinelt opened this issue Jun 11, 2024 · 1 comment
Open

Migrate to custom collector class #55

mweinelt opened this issue Jun 11, 2024 · 1 comment

Comments

@mweinelt
Copy link
Owner

mweinelt commented Jun 11, 2024

https://prometheus.github.io/client_python/collector/custom/

Recommendation from people on #prometheus on libera

https://github.com/tykling/dns_exporter could be a good example of how it can be used.

@Qwiko
Copy link
Contributor

Qwiko commented Jan 9, 2025

I am looking into this at the moment. I believe this would solve a lot of issues and workarounds that exist in the current code.
According to this: https://prometheus.io/docs/instrumenting/writing_exporters the best practise is to create new metrics on every fetch. That means for kea-exporter a complete rebuild of the code to create the metrics dynamically instead of populating static metrics with data from statistics.

I will keep on working and provide some code for others to give feedback on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants