EDSC-3075: Adds alt text to body markup #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting up to speed with the master
…thdata-search into EDSC-3075-Alt-Text
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 651 651
Lines 15823 15823
Branches 3782 3782
=======================================
Hits 13388 13388
Misses 2087 2087
Partials 348 348 Continue to review full report at Codecov.
|
macrouch
approved these changes
May 7, 2021
abbottry
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
What is the feature?
Please summarize the feature or fix.
This is to fix the 'element must contain ALT attribute' for all findings from SortSite to be 508 compliant for the issue found here #1368.
What is the Solution?
Summarize what you changed.
Following the Sort Site suggestions fond on https://www.powermapper.com/products/sortsite/rules/acchtmllinktextblank/ I added and aria-label attribute to all of the anchor tags specified in the picture provided.
What areas of the application does this impact?
List impacted areas.
The body.html file located in the repo -> earthdata-search/static/src/partials/body.html
Testing
I do not have access to run the SortSite provided https://inside.nasa.gov/webservices/support/section-508-testing-sortsite to test to ensure the issues is resolved.
Reproduction steps
Attachments
Please include relevant screenshots or files that would be helpful in reviewing and verifying this change.
Checklist