[explicit-module-boundary-types] does not respect functions exported within nested object literals #2864

eterv · 2020-12-10T08:35:29Z

First, thank you for recently bug fix #2805.

Config

{
  "rules": {
    "@typescript-eslint/explicit-module-boundary-types": ["error"]
  }
}

Code

interface Foo {
  Q: {
    f: (x: number, y: number) => number;
  };
}
export const a: Foo = {
  Q: {
    f: (x, y) => {
      console.log('Test');
      return x + y;
    },
  },
};

Or

interface Type1 {
  sub: Type2;
}
interface Type2 {
  f: (x: number, y: number) => number;
}
export const b: Type1 = {
  sub: {
    f: (x, y) => {
      console.log('Test');
      return x + y;
    },
  },
};

Expected Result

No errors; the export has an explicit type defined for all members.

Actual Result

"Missing return type on function."
"Argument 'x' should be typed."

package	version
@typescript-eslint/eslint-plugin	4.9.1
@typescript-eslint/parser	4.9.1
TypeScript	4.1.2
ESLint	7.15.0
node	14.15.0
npm	6.14.8

The text was updated successfully, but these errors were encountered:

ccaspers · 2021-01-07T16:41:05Z

I also ran into this issue. Repo with working reproduction can be found here: https://github.com/ccaspers/explicit-module-boundary-types

grumd · 2021-03-12T15:16:35Z

I'll look into making a PR for this soon.

grumd · 2021-03-12T16:22:26Z

Added a PR as you can see, meanwhile as a workaround you can use my fork as your npm dependency:

"@typescript-eslint/eslint-plugin": "https://gitpkg.now.sh/grumd/typescript-eslint/packages/eslint-plugin?build",

Edit: "@typescript-eslint/eslint-plugin": "4.17.1-alpha.14" or later now works too

…ted to functions in nested object properties (#3178)

… 4.18.0 (#714) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.17.0 to 4.18.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/eslint-plugin's releases</code></a>.</em></p> <blockquote> <h2>v4.18.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] fixes <a href="https://github.com/typescript-eslint/typescript-eslint/issues/2864">#2864</a> related to functions in nested object properties (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3178">#3178</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/55e1fbaca985b500cad1cc9ec25717b18cf5a17b">55e1fba</a>)</li> <li><strong>eslint-plugin:</strong> [no-extran-class] allowWithDecorator should ignore other errors (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3160">#3160</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/a1486736d8ef3555832ddfb27fd0980368b363f5">a148673</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> add package type declaration (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3164">#3164</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/08b058a7a6db3b59c28753bb322717e1fee44d1f">08b058a</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md"><code>@typescript-eslint/eslint-plugin's changelog</code></a>.</em></p> <blockquote> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] fixes <a href="https://github.com/typescript-eslint/typescript-eslint/issues/2864">#2864</a> related to functions in nested object properties (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3178">#3178</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/55e1fbaca985b500cad1cc9ec25717b18cf5a17b">55e1fba</a>)</li> <li><strong>eslint-plugin:</strong> [no-extran-class] allowWithDecorator should ignore other errors (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3160">#3160</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/a1486736d8ef3555832ddfb27fd0980368b363f5">a148673</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> add package type declaration (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3164">#3164</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/08b058a7a6db3b59c28753bb322717e1fee44d1f">08b058a</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/3f4e9be8f89639319b1d97a54d69a5a7c07e1ff5"><code>3f4e9be</code></a> chore: publish v4.18.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/55e1fbaca985b500cad1cc9ec25717b18cf5a17b"><code>55e1fba</code></a> fix(eslint-plugin): [explicit-module-boundary-types] fixes <a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/2864">#2864</a> related to f...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/08b058a7a6db3b59c28753bb322717e1fee44d1f"><code>08b058a</code></a> feat(eslint-plugin): add package type declaration (<a href="https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin/issues/3164">#3164</a>)</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/a1486736d8ef3555832ddfb27fd0980368b363f5"><code>a148673</code></a> fix(eslint-plugin): [no-extran-class] allowWithDecorator should ignore other ...</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/d3086d8acc6092964d98747d782417225871cb0b"><code>d3086d8</code></a> docs(eslint-plugin): [no-floating-promises] correct typo in 'allowAsStatement...</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.18.0/packages/eslint-plugin">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/eslint-plugin&package-manager=npm_and_yarn&previous-version=4.17.0&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>

…#102) [//]: # (dependabot-start) ⚠️ **Dependabot is rebasing this PR** ⚠️ If you make any changes to it yourself then they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.17.0 to 4.18.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser's releases</code></a>.</em></p> <blockquote> <h2>v4.18.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] fixes <a href="https://github.com/typescript-eslint/typescript-eslint/issues/2864">#2864</a> related to functions in nested object properties (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3178">#3178</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/55e1fbaca985b500cad1cc9ec25717b18cf5a17b">55e1fba</a>)</li> <li><strong>eslint-plugin:</strong> [no-extran-class] allowWithDecorator should ignore other errors (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3160">#3160</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/a1486736d8ef3555832ddfb27fd0980368b363f5">a148673</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> add package type declaration (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3164">#3164</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/08b058a7a6db3b59c28753bb322717e1fee44d1f">08b058a</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser's changelog</code></a>.</em></p> <blockquote> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <p><strong>Note:</strong> Version bump only for package @typescript-eslint/parser</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/3f4e9be8f89639319b1d97a54d69a5a7c07e1ff5"><code>3f4e9be</code></a> chore: publish v4.18.0</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.18.0/packages/parser">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/parser&package-manager=npm_and_yarn&previous-version=4.17.0&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

…#59) Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 4.16.1 to 4.18.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/releases"><code>@typescript-eslint/parser's releases</code></a>.</em></p> <blockquote> <h2>v4.18.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [explicit-module-boundary-types] fixes <a href="https://github.com/typescript-eslint/typescript-eslint/issues/2864">#2864</a> related to functions in nested object properties (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3178">#3178</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/55e1fbaca985b500cad1cc9ec25717b18cf5a17b">55e1fba</a>)</li> <li><strong>eslint-plugin:</strong> [no-extran-class] allowWithDecorator should ignore other errors (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3160">#3160</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/a1486736d8ef3555832ddfb27fd0980368b363f5">a148673</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> add package type declaration (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3164">#3164</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/08b058a7a6db3b59c28753bb322717e1fee44d1f">08b058a</a>)</li> </ul> <h2>v4.17.0</h2> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.16.1...v4.17.0">4.17.0</a> (2021-03-08)</h1> <h3>Bug Fixes</h3> <ul> <li><strong>eslint-plugin:</strong> [no-unnecessary-type-assertion] handle assignment (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/3133">#3133</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/cb2256168c67e0383083673a5afe77076de49da5">cb22561</a>)</li> </ul> <h3>Features</h3> <ul> <li><strong>eslint-plugin:</strong> [strict-bool-expr] add fixes and suggestions (<a href="https://github.com/typescript-eslint/typescript-eslint/issues/2847">#2847</a>) (<a href="https://github.com/typescript-eslint/typescript-eslint/commit/3f9e9a1e9fc3e507bd01d1913ef642cd129de402">3f9e9a1</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md"><code>@typescript-eslint/parser's changelog</code></a>.</em></p> <blockquote> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.17.0...v4.18.0">4.18.0</a> (2021-03-15)</h1> <p><strong>Note:</strong> Version bump only for package @typescript-eslint/parser</p> <h1><a href="https://github.com/typescript-eslint/typescript-eslint/compare/v4.16.1...v4.17.0">4.17.0</a> (2021-03-08)</h1> <p><strong>Note:</strong> Version bump only for package @typescript-eslint/parser</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/3f4e9be8f89639319b1d97a54d69a5a7c07e1ff5"><code>3f4e9be</code></a> chore: publish v4.18.0</li> <li><a href="https://github.com/typescript-eslint/typescript-eslint/commit/dd25790a435edef78f6e972ab197b0bd0cfac0f4"><code>dd25790</code></a> chore: publish v4.17.0</li> <li>See full diff in <a href="https://github.com/typescript-eslint/typescript-eslint/commits/v4.18.0/packages/parser">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=@typescript-eslint/parser&package-manager=npm_and_yarn&previous-version=4.16.1&new-version=4.18.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually </details>

eterv added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for team members to take a look labels Dec 10, 2020

eterv changed the title ~~[explicit-module-boundary-types] does not respect functions exported within array or object literals~~ [explicit-module-boundary-types] does not respect functions exported within nested object literals Dec 10, 2020

bradzacher added bug Something isn't working and removed triage Waiting for team members to take a look labels Dec 10, 2020

ccaspers mentioned this issue Jan 7, 2021

[explicit-module-boundary-types] Warning for Return Types and Argument Types on Nested Functions #2925

Closed

3 tasks

grumd mentioned this issue Mar 12, 2021

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 related to functions in nested object properties #3178

Merged

bradzacher closed this as completed in #3178 Mar 15, 2021

bradzacher pushed a commit that referenced this issue Mar 15, 2021

fix(eslint-plugin): [explicit-module-boundary-types] fixes #2864 rela…

55e1fba

…ted to functions in nested object properties (#3178)

This was referenced Mar 18, 2021

chore(deps-dev): bump @typescript-eslint/eslint-plugin from 4.11.0 to 4.18.0 activescott/web-app-stack#14

Merged

chore(deps-dev): bump @typescript-eslint/parser from 4.11.0 to 4.18.0 activescott/web-app-stack#15

Closed

Obi-Dann mentioned this issue Apr 10, 2021

Test Upgrade all dependencies AurorNZ/report-updated-dependencies#7

Draft

github-actions bot mentioned this issue Apr 12, 2021

Implement GitHub action AurorNZ/report-updated-dependencies#9

Merged

github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[explicit-module-boundary-types] does not respect functions exported within nested object literals #2864

[explicit-module-boundary-types] does not respect functions exported within nested object literals #2864

eterv commented Dec 10, 2020

ccaspers commented Jan 7, 2021

grumd commented Mar 12, 2021

grumd commented Mar 12, 2021 •

edited

Loading

[explicit-module-boundary-types] does not respect functions exported within nested object literals #2864

[explicit-module-boundary-types] does not respect functions exported within nested object literals #2864

Comments

eterv commented Dec 10, 2020

ccaspers commented Jan 7, 2021

grumd commented Mar 12, 2021

grumd commented Mar 12, 2021 • edited Loading

grumd commented Mar 12, 2021 •

edited

Loading