-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use /x or /mod instead of /package #287
Comments
I completely agree |
We could also add a simple redirect for |
I like this idea. I would prefer not to have /x (just to avoid confusion between x.nest.land and nest.land/x) unless we can get something working like how deno.land/x does it... Though, I think @maximousblk has looked into this before, and it may be more effort than I think. Regardless, @martonlederer's idea of a redirect from the current references would be absolutely critical. |
It can be done with cloudflare workers. We should talk about this too in our meeting |
it can also be done with vercel functions. I couldn't implement it in a simple way earlier because the URLs for the raw and web versions were way different. It won't take much effort if the routes work the same way on the web and in deno what we have now:
what we need:
then we can create a serverless function to forward the requests to the right place and deploy that to you can boil all of that down to "the site is inconsistent" |
Use the term "module" instead of "library" or "package". For clarity and consistency avoid the terms "library" and "package". Instead use "module" to refer to a single JS or TS file and also to refer to a directory of TS/JS code. I think we should use |
Hi @Maxvien! Thanks for the input. This was our original plan for the system, however, we encountered some technical issues with that. Because our API is completely separate from the site, we had to put I wouldn't be against investigating a solution to allow for the |
If I'm understanding this correctly, we should be able to get away with setting up routes in the Basically at the root of the repo we would create the {
"routes": [
{ "source": "/x/(.*)", "destination": "https://x.nest.land/$1" },
{ "source": "/std/(?<ver>[^/]+)/(.*)", "destination": "https://x.nest.land/std@$ver\$STD_VERSION/$1" }
]
} |
yes we can set the routes in the |
Right now we are using the
/package/:pkgname
route for modules.To align more with the Deno philosophy, we could switch to
/x/:modname
or/mod/:modname
The text was updated successfully, but these errors were encountered: