-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simulation code modifications #2
Comments
Hi @lazappi,
Here is some additional discussion of this experiment that we provided in the response to reviewers that may provide some additional clarification:
Tagging @jordansquair who actually wrote the Splatter fork here in case there is anything I'm missing. |
Hi @skinnider Thanks for the detailed explanation (and sorry for the slow reply!). I think I can see the use case for this and it's maybe something I should to incorporate into future versions of splatter (if I can find time to work on it properly again 😸 ). |
Hi
I have just done a journal club on your paper and we all agreed it was really interesting and useful work. I was interested in how you did the simulations. From the paper it seems like you used {splatter} but after looking at the code I was surprised to find you actually use a modified version which I found here https://github.com/jordansquair/splatter_batch.
Could you please describe what modifications you made and why you found them useful? If it seems like they might have more general uses we might also discuss if they could be contributed back to the main package.
Thanks!
The text was updated successfully, but these errors were encountered: