Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all php classes strict #17

Open
1 of 7 tasks
Tracked by #10
ChristophWurst opened this issue Dec 23, 2021 · 0 comments
Open
1 of 7 tasks
Tracked by #10

Make all php classes strict #17

ChristophWurst opened this issue Dec 23, 2021 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of overview Overview of other issues

Comments

@ChristophWurst
Copy link
Member

ChristophWurst commented Dec 23, 2021

Description

If you look at code like https://github.com/nextcloud/server/blob/master/apps/dav/lib/DAV/CustomPropertiesBackend.php then you see that not all of our php code has declare(strict_types=1); yet.

It's time to clean this up, force PHP into strict mode and out of unpredictable type juggling. This might cause some errors, but they are valid and should be fixed.

Affected components

  • CalDAV and CardDAV backends
  • Calendar
  • Calendar Resource Management
  • Contacts
  • Contacts Interaction
  • Mail

To do

Search each app for those files (bash search magic?) and fix them. If the number of files touched is large, break the PRs done into one PR per namespace.

@ChristophWurst ChristophWurst added 1. to develop Accepted and waiting to be taken care of overview Overview of other issues labels Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of overview Overview of other issues
Projects
None yet
Development

No branches or pull requests

1 participant