Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In-Constructor References shouldn't be id only #74

Open
MikeRileyGTRI opened this issue Feb 19, 2024 · 0 comments
Open

In-Constructor References shouldn't be id only #74

MikeRileyGTRI opened this issue Feb 19, 2024 · 0 comments

Comments

@MikeRileyGTRI
Copy link
Collaborator

MikeRileyGTRI commented Feb 19, 2024

Here's a constructor example from MannerOfDeath

	public MannerOfDeath(CodeableConcept manner, Decedent decedent, Certifier certifier) {
		this();
		setValue(manner);
		setSubject(new Reference(decedent.getId()));
		this.addPerformer(new Reference(certifier.getId()));
	}

With this subject reference setter; the decedent reference will only contain the id. Since 100 percent of the time; these resources are enclosed in a bundle; the references themselves should be resource provisioned; like "Patient/1234". This is a simple fix that needs to help the user with convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant