Discussing building Valhalla on ARM (relates to issues build running it on M1 and M2 macs)

[markstos]

I'm wondering if there any known issues with building Valhalla on Arm.

The issues I found seemed to be around running the x86 build on Arm Macs.

I'm considering running Valhalla on Arm servers in production due to lower hosting costs. It seems it might be possible with some small changes to the Github Actions workflow file to build a second image:

First, do a marix build with the extra platform:

  build:
    runs-on: ubuntu-latest
    strategy:
      matrix:
        platform: [linux/amd64, linux/arm64]

Later, Also use the matrix feature for the push step:

-  name: Build and push image
        uses: docker/build-push-action@v4
        with:
          platforms: ${{ matrix.platform }}
          tags: my-image:${{ matrix.platform }}

Are there extra complications that I'm missing?

[nilsnolde]

Valhalla itself is fine by now on arm64. This project here just doesn't build the appropriate image yet, see #124. Happy to review a PR, personally I have little interest. The Dockerfile will need an update as well, the base image moved to 23.04.

[nilsnolde]

btw, I'm not sure you can do a "matrix" build here. unless that push action aggregates the builds before pushing or does some other trickery with manifests. otherwise you'd simply overwrite a previous push with a new one and the previous arch wouldn't be available. we just had that problem upstream.