-
-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Github dependency updates on branch change #309
Comments
I should add, I don't want to clean all deps using 'make clean/deps' or whatever; I have amqp_client as an additional dep which takes an age to build; so I just want to clean this single dep (above). Ideally erlang.mk would detect the branch I want has changed (surely the name of the current branch is stored in deps somewhere, for it to compare ?) |
It shouldn't do it automatically at least, because it is very convenient to use symbolic links when working with your own projects as dependencies (for example cowboy with cowlib and ranch as symlinks, to work on all 3 at once; commits in the symlink don't necessarily match commits specified in the Makefile). A command to update deps would be good, though. What this command should look like is a good question however. Perhaps a "make update" along with a "make update dep=cowlib" so you can update all or one. The latter would allow working with symlinks still. But yeah, need thought, experimentation, and so on. :-) |
"make update dep=cowlib" would be near- perfect IMHO
|
I know this is a feature request, but it's painful enough to be considered as a bug. That and I'll fix it quicker. |
Here's my thoughts on this subject:
|
WELL ACTUALLY Since we are able to detect when a Makefile has changed (and trigger full recompilation) we can detect when deps have been changed and automatically update them. There's no need for a command or anything! (Well maybe if we want to follow a branch instead of a specific commit.) This doesn't account for the fact you can specify deps from the command line, but I don't think too many people do that (and if they do, I'm not sure they would want to do it to trigger a dependency update anyway). But otherwise, when the Makefile changes, it doesn't hurt to check and update dependencies. |
Closing in favor of #241 which is related. |
If I have a Makefile with a Github dependency and I change the branch from (eg) 'master' to 'dev', should the deps code be automatically updated on 'make' ? Or is there another command to do this ? I find right now I have to run 'sudo rm -r deps/my_dep' prior to 'make' which I'm guessing isn't the One True Way :-(
TIA
The text was updated successfully, but these errors were encountered: