-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workaround] Temporally fix for Smartplay feature #923
Comments
Do you have a debug log for this? It can probably be fixed. |
I could make a quick debug log but do I need to enable any debug logging inside TMDb Helper or UpNext? I am not 100% sure but I think it is a Bug in Seren not UpNext since SmartPlay almost behave the same way. |
Ah ok. I don't use Seren so I don't know what SmartPlay or Pre-emptive scraping actually do. If it is something that can be fixed in UpNext then just a normal debug logging will be fine. |
Here is my log I played 4 episodes. About Smart Play as far as I understand it is just a build in UpNext inside Seren, with the following features: Play Next popup, Still watching popup, Skip intro and Pre-emptive scraping. Quick unrelated question: |
Thanks for the explanation of Smart Play and Pre-emptive scraping. I suspect I know what the problem is - the pre-emptive scraping processes the next playlist item and then runs the plugin script, which changes the next item from a plugin url to a scraped video url. After this is done, UpNext is unable to do anything because there is no plugin url that it can use. In this case, you are right, it is a Seren issue. Ideally Seren should store the pre-scraped video url and use xbmcplugin.setResolvedUrl when the original plugin url is called, but there may be specific technical reasons why this is not done.
Sorry, should have been more clear. The log supplied is not a debug log, just a regular event log. I will need either a Kodi debug log: https://kodi.wiki/view/Log_file/Easy#Steps; or enable debug logging in UpNext: If you can get this, then I can see whether anything can be done in UpNext to workaround the problem.
It is easy enough to add this, but it may cause issues with the Kodi playback event order sequence, which is why I never tried to implement this. |
no problem man here a new one with debug logging enabled.
That a bummer, it will be nice to have and make the UpNext more polish. |
It looks like everything is actually working properly, except the TMDB Helper player file that you are using doesn't use pre-emptive scraping. You could try changing |
Nope. that bricked the player, now only scraping and does not show the results window after finishing. |
🤷 There probably should be a way to get it to work, but I don't use these plugins so I can't help. |
I'm getting a the dependency on xbmc.python version 2.25 could not be satisfied when trying to install the modded up next. I'm running 20.2 and it was tested on 21.2 which I presume runs Python 3 so I'm not sure how to get this to work or how it worked for you guys. Appreciate any help as I'm really not a tech savvy guy! |
@Needmorepixels - the zip file with |
This is a Fix for Smartplay known BUG with TMDb Helper, using @inb4after Seren Fork and Modified UpNext addon by @MoojMidge special Thanks to them.
Download:
Seren fork by inb4after.Edit: My Seren Fork with MoojMidge fix.How to Setup:
Seren Settings → Playback:
UpNext Settings → Expert:
Restart Kodi.
NOTES:
Pre-emptive scraping works half the time meaning: 1st ep works, 2nd not, 3rd works, 4th not... and so on.Edit: Fixed thanks to @MoojMidgeTested on:
The text was updated successfully, but these errors were encountered: