Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added simple benchmarks and tooling #100

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

chore: added simple benchmarks and tooling #100

wants to merge 14 commits into from

Conversation

kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Jan 16, 2025 •
edited
Loading

Description

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@kashbrti kashbrti changed the title feat: added simple benchmarks and tooling chore: added simple benchmarks and tooling Jan 16, 2025
@kashbrti kashbrti mentioned this pull request Jan 16, 2025
Open
@Savio-Sou Savio-Sou linked an issue Jan 16, 2025 that may be closed by this pull request
Add benchmarking for significant operations #97
Open
@kashbrti kashbrti mentioned this pull request Jan 20, 2025
Draft
2 tasks
@TomAFrench TomAFrench mentioned this pull request Jan 20, 2025
Merged
@TomAFrench
Copy link
Member

I've pulled the benchmarking code out from here and into #105 as this PR is blocked on another PR being merged first.

@kashbrti
Copy link
Contributor Author

@TomAFrench do I close this?

@TomAFrench
Copy link
Member

The benchmarking for functions which aren't in main is still only in this branch. If we want to keep those then we should fix the conflicts here rather than closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Noir
Status: 📋 Backlog
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add benchmarking for significant operations
2 participants
@kashbrti @TomAFrench