Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip the SSA safety checks to be opt-in #7171

Open
TomAFrench opened this issue Jan 23, 2025 · 1 comment
Open

Flip the SSA safety checks to be opt-in #7171

TomAFrench opened this issue Jan 23, 2025 · 1 comment

Comments

@TomAFrench
Copy link
Member

As mentioned in #7060, these safety checks are taking up a significant portion of compilation time and prevent some of the protocol circuits from being able to be compiled at all.

We don't need to run these checks on every compilation, instead they should be opt-in when the developer is compiling their final circuit and wants to spend time to catch potential bugs which may still be lurking.

@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 23, 2025
@rkarabut
Copy link
Contributor

I would try first to make just the lookback feature opt-in. It doesn't seem to catch a lot of bugs but it's probable that it's the main contributor to the performance hit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants