Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numaflow should call Source::Pending only for replica-id 0 #2274

Open
2 tasks
vigith opened this issue Dec 11, 2024 · 0 comments
Open
2 tasks

Numaflow should call Source::Pending only for replica-id 0 #2274

vigith opened this issue Dec 11, 2024 · 0 comments
Assignees
Labels
area/mono-vertex Mono Vertex area/source enhancement New feature or request
Milestone

Comments

@vigith
Copy link
Member

vigith commented Dec 11, 2024

Summary

We need to see whether every pod should make a pending call to the upstream source. We only read from pod-0, this will remove lot of pressure on the external source. I am worried whether we might in log run bring down the external source if the pending call is expensive. Also, for any pods other than replica-id 0, this information is meaningless.

Use Cases

  • Every deployment

Tasks

Preview Give feedback
@vigith vigith added enhancement New feature or request area/source area/mono-vertex Mono Vertex labels Dec 11, 2024
@vigith vigith added this to the 1.5 milestone Dec 11, 2024
@kohlisid kohlisid self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mono-vertex Mono Vertex area/source enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants