Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the code for Compatibility with FeynmanDiagram.jl v1.0 #36

Merged
merged 65 commits into from
Apr 10, 2024
Merged

Conversation

houpc
Copy link
Member

@houpc houpc commented Mar 30, 2024

TODO:

  1. benchmark vertex4 results
  2. update free energy, vertex3, and green
  3. improve code testing

@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2024

Codecov Report

Attention: Patch coverage is 6.36523% with 2133 lines in your changes are missing coverage. Please review.

Project coverage is 7.49%. Comparing base (1bb2a59) to head (707370c).

Files Patch % Lines
src/sigma/sigma_dk.jl 0.00% 217 Missing ⚠️
src/polarization/polarizationKW.jl 0.00% 195 Missing ⚠️
src/polarization/polarizationKT.jl 0.00% 156 Missing ⚠️
src/sigma/source_codeGV/Cwrapper_sigmaGV.jl 0.00% 112 Missing ⚠️
src/sigma/source_codeGV/Cwrapper_sigmaParquetAD.jl 0.00% 112 Missing ⚠️
.../sigma/source_codeGV/Cwrapper_sigmaParquetAD_dk.jl 0.00% 112 Missing ⚠️
src/diagram/generate.jl 0.00% 107 Missing ⚠️
src/sigma/parquetAD.jl 0.00% 107 Missing ⚠️
src/common/interaction.jl 48.50% 103 Missing ⚠️
src/polarization/polarization.jl 1.12% 88 Missing ⚠️
... and 15 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #36       +/-   ##
==========================================
- Coverage   32.81%   7.49%   -25.33%     
==========================================
  Files          34      54       +20     
  Lines        2380    4873     +2493     
==========================================
- Hits          781     365      -416     
- Misses       1599    4508     +2909     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@houpc houpc self-assigned this Mar 30, 2024
Copy link
Collaborator

@dcerkoney dcerkoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: Looks good to me!

src/ElectronLiquid.jl Outdated Show resolved Hide resolved
example/sigmadk_compile.jl Show resolved Hide resolved
example/ver4/ver4compile.jl Outdated Show resolved Hide resolved
example/ver4/ver4compileGV.jl Outdated Show resolved Hide resolved
src/freeEnergy/freeEnergy.jl Show resolved Hide resolved
src/vertex4/vertex4.jl Show resolved Hide resolved
@houpc houpc merged commit b99e1ac into master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants