Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pre-join #46

Open
lebaudantoine opened this issue Jul 18, 2024 · 6 comments
Open

Enhance pre-join #46

lebaudantoine opened this issue Jul 18, 2024 · 6 comments
Labels

Comments

@lebaudantoine
Copy link
Collaborator

lebaudantoine commented Jul 18, 2024

Feature Request

Is your feature request related to a problem or unsupported use case? Please describe.

We currently use the default Pre-join component from LiveKit, which, while convenient, has several drawbacks in terms of UX and accessibility.

First, the dropdown menu serves two purposes: enabling/disabling data and selecting the data source. This dual functionality can be confusing for users.

Second, the layout of this page needs improvement for a better user experience.

Lastly, we should consider whether to add a pre-join screen when creating a new meeting. If users have a preferred configuration saved, we might want to skip this screen when they create a meeting.

I've designed a pre-join mockup, inspired by Google's interface. Let me know what you think.

Please refer to the mockup page in the figma file

Capture d’écran 2024-07-18 à 22 09 34

@lebaudantoine
Copy link
Collaborator Author

@rouja shares the same feedbacks, it's quite frustrating having a pre-join screen when you just create a meeting.

@lebaudantoine
Copy link
Collaborator Author

PR opened by @manuhabitela #106. Still draft, I've started merging some parts.

@lebaudantoine
Copy link
Collaborator Author

lebaudantoine commented Nov 14, 2024

Additional Feedback:

  1. Pre-join Enhancement: Add a background blur toggle button before entering the room (similar to GMeet's implementation)

Image

  1. Layout Issue: The horizontal layout poses problems for agents with low-resolution public screens: some users can't even see the join button due to their screen constraints.

Image

  1. Make sure can select their appropriate Audio / Video input and Audio output. We should work for all OS and all browser, It's not the case, I fucked up the code, it works on my machine, but not on all machines.

@lebaudantoine
Copy link
Collaborator Author

It's an opportunity to investigate issue #212. As we would reuse the same piece of code for input/output selection. I used the default hook from LiveKit here. Let's discuss it IRL.

@lebaudantoine
Copy link
Collaborator Author

Pre-join screen will automatically populate usernames using ProConnect full names once backend serialization (issue #206) is completed.

@lebaudantoine
Copy link
Collaborator Author

Enable mic testing, to make sure your mic is working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog
Development

No branches or pull requests

2 participants