Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

History shows duplicate commands #4176

Open
nus-pe-bot opened this issue Nov 15, 2019 · 1 comment
Open

History shows duplicate commands #4176

nus-pe-bot opened this issue Nov 15, 2019 · 1 comment

Comments

@nus-pe-bot
Copy link

Steps:

  1. Enter this command edit 2 p/3.99 n/Fried Rice2 and press enter
  2. Enter this command edit 2 n/Fried Rice2 p/3.99 and press enter
  3. They are both the same command.
  4. history and hit enter:

image.png

  1. But user guide says history does not show duplicate commands:

image.png


[original: nus-cs2103-AY1920S1/pe-interim#4198]
@fatclarence
Copy link
Contributor

fatclarence commented Nov 18, 2019

Team's Response

Thank you for your response to our application.

Although these commands are commands with duplicate parameters, they are not in the same order, thus they are not exactly duplicate commands. Furthermore, we do not see an reason why a user will do the same command, with the same parameters, in a format that is different. It does not appear to us that this will happen on a very regular basis because it does not value-add to the user/developer at all, to flip the order of parameters just because they want to achieve the same function from the application.

Thus, even though we note that this is a bug we could consider, however, the flaw is unlikely to affect normal operations of the product, and it will only appear in very rare occasions, because the user/developer has no reason to produce commands with duplicate parameters in a different order for the parameters in any instance at all. It will thus, only cause users/developers minor inconvenience only. Thus, this bug would have only been accepted as a bug with low severity.

Adding on, the commands are in fact still typed differently thus, as stated in Section 3.1.2 of our User Guide, we do not store commands if they are duplicates, and commands that are typed differently as identified here are not duplicates. Thus, this is expected behaviour and arguably out of scope.

Duplicate status (if any):

--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants