XML/HTML Formatter empties style attributs #35

neoscaler · 2015-01-28T12:48:14Z

The XML/HTML formatter empties style attributs. For example, if you have a tag like this in your HTML/XML file:

<th style="#{cc.attrs.hidden ? 'display:none' : ''}" >

Ater hitting CTRL+SHIFT+F the style attribute is empty:

<th style="" >

Disabling "Automatically close attribute values" did not help. Any ideas?

The text was updated successfully, but these errors were encountered:

hohwille · 2015-01-28T14:12:01Z

Interesting observation. From an XML perspective this a bug of the Eclipse formatter. But we have to figure out if this is actually a feature that wants to prevent using style attributes in HTML and that we need to switch off. So far I think it is a bug...

hohwille · 2015-01-28T14:18:31Z

I created this test.html file and can confirm and reproduce the bug:

<html>
<head/>
<body>
<table>
<tr>
<th style="#{cc.attrs.hidden ? 'display:none' : ''}" >Bla</th>
</tr>
</table>
</body>
</html>

hohwille · 2015-01-28T14:22:09Z

I can add any content to the style attribute and it gets removed on formatting while other attributes (e.g. class) remain as is. This seems to be more of a feature than a bug. I am still clueless where to switch it off.

hohwille · 2015-01-28T14:29:06Z

If the file is named text.xml instead, the error does not occur. So it is a HTML feature of Eclipse...

maybeec · 2015-01-31T21:25:38Z

I only found this: https://bugs.eclipse.org/bugs/show_bug.cgi?id=358114
But unfortunately it does not describe in detail why this issue has not been resolved.

maybeec · 2015-01-31T22:00:05Z

I had a look into eclipse source code regarding this.
What the formatter tries to do is to format the style contents using a CSSFormatter. If this does not work, the code tries to get any other Formatter which can handle the style value. Therefore, we do not really now which formatter breaks our style attributes.

It would be nice if there was some kind of a switch for disabling style formatting, but currently this seems to be not the case :(

maybeec · 2015-02-02T10:08:38Z

This is also a very nice example where your style will be destroyed:
<body style="text-align: #{bundle['something']}">
becomes
<body style="text-align: #{bundle['something']">

hohwille · 2015-06-22T13:33:33Z

This is really an Eclipse JDT bug and not related to oasp4j-ide:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=358114

There is pretty much nothing we can do about it except for waiting and hoping for Eclipse Mars release to fix it.

neoscaler added bug question labels Jan 28, 2015

hohwille added software-package settings-package labels Mar 5, 2015

hohwille added a commit that referenced this issue May 21, 2015

#35: fixed

8a7fb07

hohwille mentioned this issue May 21, 2015

improve unix support #53

Closed

2 tasks

hohwille removed settings-package question labels Jun 22, 2015

hohwille added this to the backlog milestone Jun 22, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

XML/HTML Formatter empties style attributs #35

XML/HTML Formatter empties style attributs #35

neoscaler commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

maybeec commented Jan 31, 2015

maybeec commented Jan 31, 2015

maybeec commented Feb 2, 2015

hohwille commented Jun 22, 2015

XML/HTML Formatter empties style attributs #35

XML/HTML Formatter empties style attributs #35

Comments

neoscaler commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

hohwille commented Jan 28, 2015

maybeec commented Jan 31, 2015

maybeec commented Jan 31, 2015

maybeec commented Feb 2, 2015

hohwille commented Jun 22, 2015