-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve WW3 mesh cap to allow using vortex formulation in ocean side #11
Comments
The |
from @DeniseWorthen email:In wav_import_export there are several "calc" routines which we moved over from the old esmf cap to the new mesh cap. I think some of the fields I see listed (like the stokes-drift spectrum, calcstokes3d) are there in the old cap, but were not added to the new cap. I think it is straightforward to add them to the new cap. Some of the other fields---well, I have no idea what internal WW3 fields correspond to the needed export. But, if it is calculated as a "history" field in WW3, I think you could make them available by adding additional "calc" routines in wav_import_export. For example, in wav_grdout, I see varatts( "BHD ", "BHD ", "Bernoulli head (J term) ", "m2 s-2 ", " ", .false.) and if I look in w3iogomd, I see how that term is calculated on LN 1653. I think you can find the bottom momentum fluxes also. As for units, I'm not 100% sure I got them right when I wrote the wav_grdout. Ana has found a couple of errors (I still have on my list to fix these!). I think you'll need to rely on wave modelers to be entirely sure of the units. |
@uturuncoglu @DeniseWorthen transferring conversation on this issue from email to GH! thx |
For point of clarify, you do want any export fields to be calculated in the cap, and not just use them from the internal fields that WW3 might calculate as an output variable. The reason is that the output variables are only calculated at some set frequency, and you want the export fields to be updated at each modelAdvance. See NOAA-EMC#843 |
@DeniseWorthen Yes, it would be nice to have them in the cap and updated with coupling frequency. It would be also nice to have them in the output but we could still output import and export states for debugging purpose. |
from @DeniseWorthen: w3ounfmetamd.F90 is script with BHD, etc. units as above... |
Denise Worthen - NOAA Affiliate |
Denise Worthen - NOAA Affiliate |
See in this file (in ufs-weather there is one) in application level: something like this: |
|
Just to document chats from the meeting:Jana Haddad - NOAA Affiliate |
Thank you all! Here is the list of arrays we need from WW3:
|
Take the bottom momentum fields as an example: It appears to be calculated in
This is the code (and any preceding code on which it depends) which would need to be added in
a) define pointers to the esmf fields:
b) check that the field is required in the export state using and get pointers to the fields
c) Create a "calc" routine to calculate the fields, replicating whatever is required from the
At this point, the bottom stress should be ready to be exported by WW3 at every model advance. There is more to be done however to get them sent to another component:
|
Summary from meeting 5/28:
Next steps:need to eventually merge import_export work that's already done for the 2d coupling:
in the meantime:
attendees: @DeniseWorthen @saeed-moghimi-noaa @josephzhang8 @pvelissariou1 @aliabdolali @AliS-Noaa Saeideh Banihashemi @yunfangsun |
Here is the history showing Ufuk's addition of radiation stress components to wav_import_export.f90, on the UFS Coastal side: He added to advertise_fields SR:
and corrected those names in export_fields SR. Looks like those changes have not been merged to UFS-WM's WW3 branch. See here. |
I need to amend what I wrote previously, because it appears that
|
Thx @DeniseWorthen for your instructions! |
@josephzhang8 Thanks, I should have looked more carefully. I think it should actually just be
since taubbl allocated as (nsealm,2) |
That makes sense. Thx @DeniseWorthen |
The list of WW3 variables SCHISM needs (from OASIS ): |
@aliabdolali many thanks for taking time help us set up the test! You can find the setup for SCHISM-WWM for the analytical case at: The web may warn you about potential risk; just accept and you'll see the dir (our IT guy is still looking to upgrade). Let me know if you have any questions. Thx! |
Hi Dan, Would please plot time series of Hsig for a node in the middle of the open boundary and the other one a few nodes inside the domain (see figue attached here). I believe these wave height time-series from both schism-ww3 and schism-wwm should be almost identical. If they are not in agreement then we need to bring it up to discuss with @aliabdolali and others. Thanks, |
Obviously the boundary spectrum definition for the both models are not consistent i.e. the amount of energy we enter to these domains are not the same where it need to be identical. @aliabdolali @danishyo Thanks, |
Hi @danishyo , Could you please let me know your most recent case configurations and the source codes of the schism-ww3 case and schism-wwm on Hercules? I would like to compare some outputs, spectra, hs etc. Thank you! |
Hi @yunfangsun |
Hi @yunfangsun |
Hi @danishyo , Thank you |
From our meeting on Oct 16, 2024:From meeting on 10/16/2024
|
@janahaddad Here are inputs for Sandy including all nml and netcdf files: |
Hi @danishyo |
@janahaddad I emailed you the Sandy-Duck guide tutorial, please add it to GD and share with the team |
Hi @danishyo @josephzhang8 @danishyo would you please add the graphics here? Thanks to All |
@aliabdolali |
Hi @aliabdolali , Thank you for the files, could you please also share the switch file for the Duck case? Thank you again! |
Try the same you used for Ian |
@danishyo: to output WWM directions in maths convention, you just need to change (in &PROC) LNAUTOUT=F |
Is this also the case when you want to force spectra boundary condition to model (as input to force) in maths convention? Thanks. |
Yes, another flag LNAUTIN controls that. My understanding is that compass convention is the default in wave modeling and few people use the math convention |
Hi @saeed-moghimi-noaa |
Hi @aliabdolali , I would like to reproduce Duck Case 1 within WW3. The Thank you very much! |
untitled folder.zip |
Hi @uturuncoglu, I am testing Ali's Sandy case with feature/schism_3d branch (51fc37a). /home/feiye/work2_Dan/UFS/YunFang_case/ufs-coastal_schism_3d_20240911/ufs-weather-model/WW3/model/src/wav_shr_mod.F90(11): error #7013: This module file was not generated by any release of this compiler. [ESMF] And this is not happened on Frontera. |
@danishyo it could be and the branch that you are using might need to sync with upstream. The current head of UFS Coastal is working fine. Do you want me to go ahead and sync |
Hi @uturuncoglu , now I am able to compile without problem on Hercules. However, when I tried another larger case (smaller domain in SCHISM, larger domain in WW3 ) with similar settings and the same exec file. PET log shows the following: 20241204 003754.850 INFO PET0000 (esmFldsExchange_coastal_attr): called |
@uturuncoglu, it looks like this may be related to the ESMF library interpolation issue right? |
@janahaddad I think I respond this via mail but it would be also nice to add in here. This seems an issue in the mesh. If you look at the error message it has |
Background
[based on @uturuncoglu email] UFS Coastal is working on coupling WW3 and SCHISM. We're able to run 2D configurations of SCHISM + WW3 with mesh cap (or NCAR cap) without any issues, but we are preparing the way for running in 3D mode (https://github.com/oceanmodeling/ufs-coastal/issues/32). This requires additional fields from WW3.
The aim is to add missing fields to the WW3 cap (I think they are already available through OASIS complier) and complete the wiring with the SCHSIM (the interaction with wave with new formulation is already implemented) to enable 3d coupling
Info needed to proceed
https://github.com/NOAA-EMC/WW3/blob/d9b3172f4197c65d471662c6952a668152d71230/model/src/wav_import_export.F90#L138
WW3/model/src/wav_import_export.F90
Line 139 in 80a5ad5
@DeniseWorthen we will follow up for a description of what we're searching for here !
cc @josephzhang8 @uturuncoglu @yunfangsun @saeed-moghimi-noaa @anntsay
The text was updated successfully, but these errors were encountered: