Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible to create really big files, and thus take up all the space on hard disk #3

Open
Amaz1 opened this issue Feb 6, 2017 · 4 comments

Comments

@Amaz1
Copy link

Amaz1 commented Feb 6, 2017

I was able to do this, with help from a random word generator and copy + paste:
screenshot_2017-02-06_21-37-52
(Ignore the usage, just the size of the folder.)

I was able to do this by making a big file by copying and pasting this code a few times, so I ended up with a file ~200mb. (Using clear fixed any lag caused by the large amount of characters on screen.) When I had a suitably large file, using this code, I was able to make copies of it: for i = 1, 50 do fs.copy("test", "test" .. i) end That made ~10gb of files. I don't think there's a maximum limit to the number of files you can copy in one go. (I'm surprised it doesn't time out.) Also, while copying the files, the game hangs completely.

Maybe a size limit needs to be added either to individual files, or to the computer folder as a whole, to prevent computers being abused in this way. (Even with a size limit on individual files (or even computers), a player could still make a huge amount of them, it would just take a bit longer. And even if players had their own size limit, they could still make multiple accounts...)

I'm really enjoying playing around with the mod - great work!

@octacian
Copy link
Owner

octacian commented Feb 7, 2017

I had forgotten entirely about this, thanks for opening the issue!

I plan on implemented storage devices of different capacities required for using computers. I hadn't thought about copy-pasting big files either, I'll either have to use something like LuaJIT (I think), to create different threads per-player, or limit the max file size (which wouldn't be too hard).

ATM I'm trying to get digicompute working on Windows, so won't have a chance to do the above for a few days as I have to get a basic OS in place first.

EDIT: also, out of curiosity, what OS are you running? It looks cool, so :P

@Amaz1
Copy link
Author

Amaz1 commented Feb 7, 2017

Okay, great!

I'm using Arch Linux, with awesome window manager and numix circle icon theme. And my file manager is thunar.

@Beanzilla
Copy link

I think this also depends on who's doing it... Perhaps include some way to notify the server owner about mod abuse.

If the player exceeds the filesize in short periods of time report it to the server owner.

Not sure about the limit's in the game ATM but if all of lua is accessable the player could make Forkbombs or even memory hogging.

@octacian
Copy link
Owner

Quite frankly I don't think I would trust this mod on a public server at the moment. The Lua API is pretty heavily sandboxed, but I don't think it would be at all difficult to hog memory or for that matter flat out DDOS the server with some particularly complex long-running code. I may have introduced some limitations for memory, but it's been a while and I don't remember.

Ultimately I would like to take a set of sane limitations for CPU time, memory usage, and storage space and turn them into game elements; with each limitation upgradable via a set of in-game components. Problem of course is that I haven't had time for Minetest in a very long time, so while I'll happily merge PRs and add maintainers to the repository, I'm very unlikely to do anything myself anytime soon - if ever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants