-
-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Importing md file #142
Comments
This is a pretty interesting feature, but I believe the implementation needs to be carefully considered. |
I think a good path forward would be to complete #6 first for custom sections, then parse the readmes for titles. We should make it clear that it is intended to be used for md files that were created with readme.so, or at least formatted the same (h2's for headers) When we implement this, it would be great if the user could either upload the file or paste the file contents in. I believe more people use the copy functionality than the download functionality currently. |
I can pick this up once #6 is closed, if that is okay with you. We can always discuss the smaller details when development starts. |
Sounds good to me |
@jose-vale are you still interested in working on this? |
Yes, although I will only be able to pick it up next week. I was waiting for the custom sections development, will that need to be implemented in the context of this feature? |
Custom sections has been implemented! |
Ok, must have missed that update. Will start this as soon as I can. |
Hey @octokatherine, I'm currently working on this. Do you have an icon for the import and paste buttons? Also, I will only add translations to PT and EN, the rest will need to be done either at a later date, or by other contributors once I open the PR. Is that okay? |
@jose-vale Are you still working on this? |
I started working on it, but have not had the time lately. Do you want to pick it up? |
Yeah I might work with you on it together. |
@MicahBCode I've added you to the repo. I don't recall how far along the feature was, but if you need anything, let me know. |
In a somewhat related note: a cool and pretty rapid addition could be the one to export the metadata present in the local storage as json to let us export and import our work. Let me know if you are interested I can either open a new issue and I might also be able to work on this. |
Hey @fatihsezgin @jose-vale @octokatherine @MicahBCode Based on issue #264 I've gone ahead and implemented something very similar in this PR #274 This issue seems very similar so happy to incorporate feedback from here for my implementation? |
@BrookJeynes The preview of this import and export looks and works great https://readme-so-git-fork-brookjeynes-264-impo-05d353-katherineoelsner.vercel.app/editor Hope it can be merged soon. |
Was this feature abandoned @BrookJeynes your preview looked fantastic, especially for self hosting where you don't want to lose custom sections or have a template in mind you want to use. |
Sorry about that, here's the latest update #288 |
Thank you @BrookJeynes really hope this comes to fruition, great work! |
It would be very useful if we can upload a md file that is also has been created in the readme.so.
The text was updated successfully, but these errors were encountered: