Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't reorder pinned tabs properly when multi-rows #376

Open
Merci-chao opened this issue Jan 3, 2025 · 2 comments
Open

Can't reorder pinned tabs properly when multi-rows #376

Merci-chao opened this issue Jan 3, 2025 · 2 comments

Comments

@Merci-chao
Copy link

When multi-rows:

  • Position of drop indicator incorrect
  • Pinned tabs on the right cannot be moved to the left
@Merci-chao Merci-chao changed the title Can't move reorder pinned tabs properly when multi-rows Can't reorder pinned tabs properly when multi-rows Jan 3, 2025
@onemen
Copy link
Owner

onemen commented Jan 5, 2025

Can you provide screenshot/video of the issue?

How can you position pinned tabs on the right?

Regarding drop indicator, one issue I see is when you drop a link to the pinned tab area the link open as new non pinned tab.

@Merci-chao
Copy link
Author

Merci-chao commented Jan 5, 2025

The problem only happens when tab scrollbox is overflowing and it is not scrolled to the start (scrollTop > 0). The tabs on right I meant is "the pinned tabs except the first one". Say A B C D 4 pinned tabs, both B C D can't be moved to the left side of A, and the drop indicator always stays before the first normal tab as it is the drop point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants