Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep old descriptor revisions #381

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keep old descriptor revisions #381

wants to merge 2 commits into from

Conversation

sdsantos
Copy link
Collaborator

@sdsantos sdsantos commented Jan 14, 2025 •
edited
Loading

Closes #368

@sdsantos sdsantos force-pushed the keep-old-descriptors branch from f2b494a to 5b48852 Compare January 14, 2025 18:34
@sdsantos sdsantos marked this pull request as ready for review January 15, 2025 14:11
aanorbel
aanorbel approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@aanorbel aanorbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐳

composeApp/src/commonMain/kotlin/org/ooni/probe/data/repositories/TestDescriptorRepository.kt
@@ -19,19 +20,27 @@ class TestDescriptorRepository(
private val json: Json,
private val backgroundContext: CoroutineContext,
) {
fun list() =
// Warning: this list will bring duplicated descriptors of different revisions
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should use kdoc here

Copy link
Collaborator Author

@sdsantos sdsantos Jan 15, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do it on a next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanorbel aanorbel aanorbel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Keep old descriptor revisions on the database. Add the descriptor_revision column to the Result table.
2 participants
@sdsantos @aanorbel