-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
construction materials: record tests undertaken as part of construction #405
Comments
I think the codes can be singular. |
@jpmckinney just to check what you mean there, do you mean that the code for e.g. "Foundations" can be "foundation"? |
I think both the code and title can be singular, as is already the case with soil. |
The initially suggested list is made up of 3 different types of thing:
Given the modelling proposed I think this is an issue, for example if a user gave the following: {
"social": {
"healthAndSafety": {
"materialTests": {
"tests": [
"retainingWall",
"concrete",
"soil",
"thickness"
]
}
}
}
} it ambiguous how these codes relate to each other. Was the “thickness” test conducted on both “concrete” AND “soil” or just one of the materials? Or maybe it was only conducted on the “retainingWall” and not the other elements that may also be made of “concrete”? By combining all of these things in a single list it risks making it seem like a project has conducted far more tests than they actually have. Expecting the I see 2 potential solutions:
The 2nd option is complex, possibly too complex but does allow all of the information to be presented in a structured format. The 1st option is significantly simplier but more restrictive (although all of the information can still be shared in the associated documents) What do you think @duncandewhurst @EvelynDinora @mgraca-prado |
Good catch. It would help to know how this information is typically tracked or monitored. It seems a bit strange to me that some source system would only have tracked that a "thickness test" had been performed. |
@EvelynDinora @mgraca-prado any thoughts on this? Do you have access to any datasets that demonstrate how this information is currently currently being captured? Or could you ask Hamish (I think I remember in a previous chat Maria you said that this data point was his suggestion)? |
@odscjen let me check with Hamish. I will come back to you ASAP |
Hi @odscjen and @EvelynDinora , |
ah ha, thanks @mgraca-prado that's really useful. So to keep this simple (and to avoid having to keep any codelists up-to-date with multiple construction standards that aren't open) we could make the codelist "constructionMaterial" and use the list of materials Maria has listed in the previous comment. And then in the mapping instruct the publisher to list the specific standard tests they've conducted. e.g. {
"social": {
"healthAndSafety": {
"materialTests": {
"materials": [
"masonry",
"concrete",
"aggregateAndRock"
],
"description": "ASTM C617, ASTM C1231, ASTM C88"
}
}
}
} With the mapping guidance
@jpmckinney @mgraca-prado @EvelynDinora how does that sound? |
constructionMaterials.csv open codelist
Sources for definitions
Notes
|
@jpmckinney @EvelynDinora just checking if either of you have any comments or objections to the altered modelling suggested in #405 (comment)? Or to the code descriptions in #405 (comment) (also @mgraca-prado for these) |
Looks good. I suggest removing "or dirt" from soil. Although Wikipedia says so, it's easy to find sources that distinguish the two: basically, things can grow in soil, but not necessarily dirt (depending on its definition). But, if we need to cover dirt, I suppose we could keep it in the definition. Cement, as defined, can include mortar. Not sure if anything to do about that. Other small changes:
|
Thanks @jpmckinney I've updated the descriptions according to your suggestions. I've left cement as is. In the case were the publisher is using cement as a mortar hopefully the standard they've based their test on will make it clear which code they should use. |
had a thumbs up from Maria and the ok from James (with suggestions which have now been applied) so I'm moving this to Agreed. |
waiting for #428 to be merged before starting PR for this. |
Good to go :-) |
Background
This issue relates to the following CoST IDS elements proposed in the CoST IDS/OC4IDS review:
Construction materials testing
Construction materials testing
Module: Social
Indicator: Health and safety
Disclosure format
[Free text to add not mentioned tests]
OC4IDS mapping
Proposal
Add a
.materialsTest
object comprising a.type
array of codes from the open materialTests codelist and a.description
. Add amaterialTests
array ofmaterialTest
objects tosocial.healthAndSafety
. Add the code ‘materialTestResults` to documentType codelist. (see the overarching social object issue for how this fits in with other social obligations related fields.)Research is still required to fully define the codelist.
Add the following fields and objects:
Add the following codes:
Example
Sources
cc @EvelynDinora
The text was updated successfully, but these errors were encountered: