Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lots: Replace Lot.status with Lot.finalStatus #224

Closed
duncandewhurst opened this issue Feb 28, 2024 · 3 comments · Fixed by open-contracting-extensions/ocds_lots_extension#49
Assignees
Labels
Core Relates to a recommended extension Schema Involves editing the schema
Milestone

Comments

@duncandewhurst
Copy link

duncandewhurst commented Feb 28, 2024

From open-contracting/standard#1648 (comment):

I noticed that docs/examples/unsuccessful_tender/tender.json has lots.status = 'unsuccessful' - should the lot extension also be updated following the same logic as the changes to tender?

Yes, please create an issue.

  • Update docs/examples/unsuccessful_tender/tender.json in the standard. Edit (James): I had added this in March, but looking at it now, I don't think an update is needed (or we did it already). On that page, tenderUpdate.json sets "finalStatus": "unsuccessful".
@duncandewhurst duncandewhurst added Schema Involves editing the schema Core Relates to a recommended extension labels Feb 28, 2024
@duncandewhurst duncandewhurst added this to the 1.2.0 milestone Feb 28, 2024
@odscjen odscjen self-assigned this Apr 3, 2024
@odscjen
Copy link

odscjen commented Apr 3, 2024

@jpmckinney the README of the lots extension contains a section entitled "How to set tender.status if lots' statuses differ?" In 1.2 this field (tender.status) is being deprecated. As we don't have a 1.2 branch for the lot extension I don't think we should update this section to refer to a field that currently only exists in the unpublished 1.2 core schema. Should I instead add a section on "How to set tender.finalStatus if lots' statuses differ?" and note that this is only relevant to publishers using OCDS 1.2?

@jpmckinney
Copy link
Member

Let's create a PR, and then add the task of merging it to #202 Once the PR is approved, we can close this issue to leave only #202 open.

@jpmckinney
Copy link
Member

And in the PR, edit the section to refer to finalStatus (with corresponding edits).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Relates to a recommended extension Schema Involves editing the schema
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants