Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export: Change multipleLines to render bullets instead of paragraphs, and make it the default #30

Open
yolile opened this issue Oct 7, 2020 · 7 comments

Comments

@yolile
Copy link
Member

yolile commented Oct 7, 2020

from @romifz comment:
Right now the ocid list is a label that puts the ocid between commas, but maybe it will be better if the list of ocids are displayed as a list with bullets as well

@sabahfromlondon
Copy link

I agree this can be visually confusing and places a cognitive load on the reader. We should have on OCID per line at the very least. Additionally the purple colour makes it look like the OCIDs are hyperlinks which they are not.

@jpmckinney
Copy link
Member

jpmckinney commented Oct 22, 2020

@sabahfromlondon Are the OCIDs purple because the tag was purple, or are they inserted as purple regardless of the color of the tag? (My understanding was that the inserted content inherited styles from the tag. In some of Datlab's templates, they changed the color of the tags to make them visually distinct.)

@sabahfromlondon
Copy link

@jpmckinney I've added a screenshot.

The tags for these as far as I can see are: {% passedExamples %} and {% failedExamples max:|5| %}

I think it's helpful to make the examples visually distinct. I had a conversation with @pindec who thought they could be mistaken for hyperlinks and I have to agree. I think the purple colour is too close to blue.

Screen Shot 2020-10-26 at 09 30 34

@jpmckinney
Copy link
Member

But what did the input template look like?

@hrubyjan
Copy link

I guess this is only a colour of the tag in the template. If you'll make the colour black the output will be also black

@duncandewhurst
Copy link

I tried adding a bullet point style to the failedExamples tag in the template and got the following error:

image

The same template works OK with the 'Normal text' style applied to the failedExamples tag.

@jpmckinney jpmckinney transferred this issue from open-contracting-archive/pelican Sep 14, 2021
@jpmckinney
Copy link
Member

Currently these sample tags take a mode argument that can be oneLine (comma-separated string) or multipleLines (consecutive paragraphs). We can change multipleLines to render bullet points, as it looks like we don't use it in any reports.

We can also change the default from oneLine to multipleLines, if that is preferred.

@jpmckinney jpmckinney changed the title Feedback report: include ocids as bullets and not as tags Export: Change multipleLines to render bullets instead of paragraphs, and make it the default Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants