-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export: Change multipleLines to render bullets instead of paragraphs, and make it the default #30
Comments
I agree this can be visually confusing and places a cognitive load on the reader. We should have on OCID per line at the very least. Additionally the purple colour makes it look like the OCIDs are hyperlinks which they are not. |
@sabahfromlondon Are the OCIDs purple because the tag was purple, or are they inserted as purple regardless of the color of the tag? (My understanding was that the inserted content inherited styles from the tag. In some of Datlab's templates, they changed the color of the tags to make them visually distinct.) |
@jpmckinney I've added a screenshot. The tags for these as far as I can see are: {% passedExamples %} and {% failedExamples max:|5| %} I think it's helpful to make the examples visually distinct. I had a conversation with @pindec who thought they could be mistaken for hyperlinks and I have to agree. I think the purple colour is too close to blue. |
But what did the input template look like? |
I guess this is only a colour of the tag in the template. If you'll make the colour black the output will be also black |
Currently these sample tags take a We can also change the default from oneLine to multipleLines, if that is preferred. |
from @romifz comment:
Right now the ocid list is a label that puts the ocid between commas, but maybe it will be better if the list of ocids are displayed as a list with bullets as well
The text was updated successfully, but these errors were encountered: