Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send 404 for error: ArgumentError: invalid value for Integer(): "6'A=0" #1046

Closed
henare opened this issue Nov 14, 2016 · 5 comments
Closed

Comments

@henare
Copy link
Member

henare commented Nov 14, 2016

This seems to be happening where a bot is hitting this path, possibly probing. We shouldn't be raising and throwing a 500 here, it should be 404.

Backtrace

line 14 of [PROJECT_ROOT]/app/controllers/comments_controller.rb: index

View full backtrace and more info at honeybadger.io

@equivalentideas equivalentideas changed the title [PlanningAlerts/production] ArgumentError: invalid value for Integer(): "6'A=0" Send 404 for error: ArgumentError: invalid value for Integer(): "6'A=0" Mar 23, 2017
@zoek1
Copy link

zoek1 commented Mar 24, 2017

Hi, can anybody show the logs? 'cause honeybadger show me that I'm not allowed and I don't know if the bug is what i reproduced.

@henare
Copy link
Member Author

henare commented Apr 13, 2017

@zoek1 it looks like it's someone probing the server. Here's a URL from Honeybadger's log you can use to test:

https://www.planningalerts.org.au/authorities/kuringgai/comments?page=4%22%20or%20(1,2)=(select*from(select%20name_const(CHAR(111,108,111,108,111,115,104,101,114),1),name_const(CHAR(111,108,111,108,111,115,104,101,114),1))a)%20--%20%22x%22=%22x

@hisayohorie
Copy link
Contributor

Due to the fix of issue#669(adding validate_page_param in application_controller.rb's before_filter, we don't get that error anymore, FYI!

@stale
Copy link

stale bot commented Aug 16, 2021

This issue has been automatically marked as stale because there has been no activity on it for a year. If you want to keep it open please make a comment and explain why this issue is still relevant. Otherwise it will be automatically closed in a week. Thank you!

@stale stale bot added the wontfix label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants