Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

H is not getting transliterated to russian #41

Open
bazuchan opened this issue Jul 28, 2023 · 4 comments
Open

H is not getting transliterated to russian #41

bazuchan opened this issue Jul 28, 2023 · 4 comments
Assignees
@georgeslabreche
Labels
bug

Comments

@bazuchan
Copy link

Was fine before commit 26a63d6
@georgeslabreche
Copy link
Collaborator

Is this related to the issue pertaining to standards that was discussed here?

@bazuchan
Copy link
Author

It's caused by same commit. The change above is just questionable, but not transliterating H is definitely bug.

@paskevich
Copy link

Agree with @bazuchan, 100% a bug
mapping.py line 111 needs change
from u"Х": u"X", u"х": u"x",
to u"Х": u"H", u"х": u"h",

@georgeslabreche georgeslabreche self-assigned this Apr 20, 2024
@bryndin
Copy link

bryndin commented Jan 8, 2025

also tests that would catch it are missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgeslabreche georgeslabreche

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bryndin @georgeslabreche @bazuchan @paskevich